Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI EPIC] Better integration with GitHub / Gitlab #63

Open
richard-cox opened this issue Jan 21, 2022 · 7 comments
Open

[UI EPIC] Better integration with GitHub / Gitlab #63

richard-cox opened this issue Jan 21, 2022 · 7 comments
Assignees
Labels
area/application area/ux Usability issue / improvement blocked-backend epic kind/enhancement New feature or request

Comments

@richard-cox
Copy link
Member

Create Application Process

  • Allow user to supply a public github / gitlab repo when creating an Application
  • User can select branch from a drop down
  • User can select a commit from a drop down

Application Detail Page

  • Show git info

Application Edit

  • Allow use to update app to run from code at a commit
@richard-cox richard-cox added the area/ux Usability issue / improvement label Feb 22, 2022
@richard-cox
Copy link
Member Author

richard-cox commented Jun 23, 2022

Validation

  • Confirm that a github url containing a commit can be used to deploy an epinio app

First Step (#149) - Use github API to create the url used by epinio to deploy an app

  • Add new github source type
  • When selected
    • user should be able to select repo/branch
    • new 'commit' step added to wizard
  • When user clicks next
    • user taken to new 'commit' step
    • user is presented with list of commits to select from
  • From these two parts we should be able to construct a url to that commit which can be used when deploying app

Notes

  • There's an existing github store which should be able to provide the info required (repos/branches/commits)
  • There's an existing GithubPicker component that isn't currenly used anywhere. We can re-purpose that to allow user to select repo/branch

Second Step (#150)

  • persist github repo, branch and commit info within the app such that we can show those details in the app detail page

Third Step (#150)

  • In the app details page allow user to see commits for repo/branch and enable them to select a commit to deploy from

Fourth Step (#173)

  • Support gitlab

Fifth Step (#327)

@richard-cox richard-cox added this to the UI 1.1 milestone Jun 23, 2022
@richard-cox richard-cox removed this from the UI 1.2 milestone Feb 6, 2023
@richard-cox richard-cox changed the title Better intergration with public GitHub / Gitlab [UI EPIC] Better integration with public GitHub / Gitlab Feb 22, 2023
@abonillabeeche
Copy link

Can we increase the priority on this issue?

@richard-cox
Copy link
Member Author

Note - Dealing with private / enterprise github/gitlab relates to step 5 of this issue

@mmartin24
Copy link
Contributor

Note - Dealing with private / enterprise github/gitlab relates to step 5 of this issue

Adding suggestion from @abonillabeeche to note gitlab.com vs Gitlab for step 5

@richard-cox
Copy link
Member Author

I've updated step 5. Note - this issues is more UI centric. I've created epinio/epinio#2236 for a more overall issue

@abonillabeeche
Copy link

abonillabeeche commented May 1, 2023

Note - Dealing with private / enterprise github/gitlab relates to step 5 of this issue

Adding suggestion from @abonillabeeche to note gitlab.com vs Gitlab for step 5

I meant, gitlab.com integration with the current epinio release (1.8.0), that expects org/name as we deploy Apps vs an on-prem URL that a local Gitlab deployment would be the consumable.

Step 5 remains auth support for gitlab.com, github.com and on-prem Gitlab.

@richard-cox
Copy link
Member Author

I think there's some misunderstanding on terms. For clarity

type url requires credentials
public github.com / gitlab.com github.com / gitlab.com No
private github.com / github.com github.com / gitlab.com Yes
Enterprise github / gitlab instance dependent (url is not github.com / gitlab.com) Yes

There's some cross-over with credentials. For instance a user could supply credentials for private github/gitlab that we would use for requests to public github/gitlab (to remove any issues with API rate limiting).

There's currently no expectation that enterprise github / gitlab will be available without credentials.

For enterprise github / gitlab we would still expect the user to enter all the usual details when deploying an app, plus a few more specific ones. So very roughly

  • Select credentials (linked to a enterprise instance with custom url)
  • Select org/project
  • Select repository
  • Select branch
  • Select commit

@abonillabeeche is that all roughly as required?

@richard-cox richard-cox changed the title [UI EPIC] Better integration with public GitHub / Gitlab [UI EPIC] Better integration with GitHub / Gitlab May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/application area/ux Usability issue / improvement blocked-backend epic kind/enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

4 participants