Address lint and type issues

Author: FrancoETrujillo

src/dali/plugin/input/csv/crypto_com_app.py

@@ -136,7 +136,7 @@ def __init__(
         self.transaction_hash = transaction_hash
         self.notes = notes
 
-    def __str__(self):
+    def __str__(self) -> str:
         return (
             f"CryptoComAppTransaction(timestamp={self.timestamp}, "
             f"description={self.description}, currency={self.currency}, "
@@ -171,10 +171,15 @@ def __init__(
         super().__init__(account_holder=account_holder, native_fiat=native_fiat)
         self.__in_csv_file: Optional[str] = in_csv_file
         self.__logger: logging.Logger = create_logger(self.__CRYPTO_COM_APP)
-        self.__remove_reverted: bool = remove_reverted_transactions
+        self.__remove_reverted: bool = False if remove_reverted_transactions is None else remove_reverted_transactions
 
     def load(self, country: AbstractCountry) -> List[AbstractTransaction]:
         csv_transactions: List[CryptoComAppTransaction] = []
+
+        if not self.__in_csv_file:
+            self.__logger.error("No input CSV file specified.")
+            raise ValueError("Input CSV file is not specified.")
+
         with open(self.__in_csv_file, encoding="utf-8") as transaction_csv_file:
             lines = reader(transaction_csv_file)
 
@@ -247,6 +252,9 @@ def handle_exchange_transaction(self, transaction: CryptoComAppTransaction) -> L
         """
         self.__logger.debug("Processing exchange transaction %s", transaction)
 
+        if not transaction.to_currency or not transaction.to_amount or not transaction.abs_float_to_amount:
+            self.__logger.warning("Exchange transaction missing 'to_currency' or 'to_amount', skipping: %s", transaction)
+            return []
         exchange_transactions_out: List[AbstractTransaction] = []
 
         try:
@@ -361,7 +369,7 @@ def handle_in_type_transaction(self, transaction: CryptoComAppTransaction) -> In
         """
 
         self.__logger.debug("Processing in transaction %s", transaction)
-        if transaction.to_currency:
+        if transaction.to_currency and transaction.to_amount:
             # If there is a to_currency, we assume is a purchase from usd to the currency
             in_currency = transaction.to_currency
             crypto_in = transaction.to_amount
@@ -398,7 +406,7 @@ def handle_in_type_transaction(self, transaction: CryptoComAppTransaction) -> In
             notes=transaction.notes,
         )
 
-    def format_time(self, time: str):
+    def format_time(self, time: str) -> str:
         """
         Convert time from "MM/DD/YYYY HH:MM" format to ISO 8601 format with UTC timezone.
         """

tests/test_crypto_com_app.py

@@ -23,7 +23,7 @@ def test_load_transactions_remove_reverted(self) -> None:
         result = plugin.load(US())
         assert len(result) == 35
 
-    def test_handle_exchange_transaction(self):
+    def test_handle_exchange_transaction(self) -> None:
         plugin = InputPlugin(
             account_holder="tester",
             in_csv_file="input/test_crypto_com_app.csv",
@@ -56,6 +56,8 @@ def test_handle_exchange_transaction(self):
         assert out_transaction.timestamp == "2022-06-15 21:58:00+0000"
         assert out_transaction.transaction_type.lower() == Keyword.SELL.value.lower()
         assert out_transaction.spot_price == "0.11888081892640755"
+        assert out_transaction.crypto_out_no_fee is not None
+        assert out_transaction.crypto_out_with_fee is not None
         assert RP2Decimal(out_transaction.crypto_out_no_fee) == RP2Decimal("259.8504164")
         assert RP2Decimal(out_transaction.crypto_out_with_fee) == RP2Decimal("259.8504164")
         assert out_transaction.crypto_fee == "0"
@@ -71,15 +73,16 @@ def test_handle_exchange_transaction(self):
         assert in_transaction.fiat_in_no_fee == "30.8912303"
         assert in_transaction.crypto_fee == "0"
 
-    def test_handle_intra_transaction(self):
+    def test_handle_intra_transaction(self) -> None:
         plugin = InputPlugin(
             account_holder="tester",
             in_csv_file="input/test_crypto_com_app.csv",
             native_fiat="USD",
         )
 
         transaction = CryptoComAppTransaction(
-            raw_data="11/21/2022 22:08,Withdraw ETH (ERC20),ETH,-0.3877,USD,421.5213882,USD,421.5213882,crypto_withdrawal,0x1646a7c9f57f5f543c498f5ebff14dab16f9c9b09dbfb50405622564b8c62762",
+            raw_data="11/21/2022 22:08,Withdraw ETH (ERC20),ETH,-0.3877,USD,421.5213882,USD,421.5213882,"
+            "crypto_withdrawal,0x1646a7c9f57f5f543c498f5ebff14dab16f9c9b09dbfb50405622564b8c62762",
             time=plugin.format_time("11/21/2022 22:08"),
             description="Withdraw ETH (ERC20)",
             currency="ETH",
@@ -103,7 +106,7 @@ def test_handle_intra_transaction(self):
         assert RP2Decimal(result.crypto_sent) == RP2Decimal("0.3877")
         assert RP2Decimal(result.crypto_received) == RP2Decimal("0.3877")
 
-    def test_handle_in_transaction(self):
+    def test_handle_in_transaction(self) -> None:
         plugin = InputPlugin(
             account_holder="tester",
             in_csv_file="input/test_crypto_com_app.csv",
@@ -134,7 +137,7 @@ def test_handle_in_transaction(self):
         assert result.fiat_in_no_fee == "25.0"
         assert result.crypto_fee == "0"
 
-    def test_handle_out_transaction(self):
+    def test_handle_out_transaction(self) -> None:
         plugin = InputPlugin(
             account_holder="tester",
             in_csv_file="input/test_crypto_com_app.csv",
@@ -165,7 +168,7 @@ def test_handle_out_transaction(self):
         assert result.crypto_fee == "0"
         assert result.crypto_out_with_fee == "0.0259378"
 
-    def test_remove_ignored_transactions(self):
+    def test_remove_ignored_transactions(self) -> None:
         plugin = InputPlugin(
             account_holder="tester",
             in_csv_file="input/test_crypto_com_app.csv",
@@ -201,7 +204,7 @@ def test_remove_ignored_transactions(self):
         assert len(result) == 1
         assert result[0].transaction_kind == "referral_gift"
 
-    def test_revert_reverted_transactions(self):
+    def test_revert_reverted_transactions(self) -> None:
         plugin = InputPlugin(
             account_holder="tester",
             in_csv_file="input/test_crypto_com_app.csv",
@@ -236,7 +239,7 @@ def test_revert_reverted_transactions(self):
         result = plugin.remove_reverted_csv_transactions(transactions)
         assert len(result) == 0
 
-    def test_date_conversion(self):
+    def test_date_conversion(self) -> None:
         # Test the date conversion from string to datetime
         in_date_str = "2/29/2024 6:42"
         expected_date = "2024-02-29T06:42:00+00:00"