Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues in the 404 page template #2754

Open
BorghildSelle opened this issue Jan 16, 2025 · 7 comments
Open

Issues in the 404 page template #2754

BorghildSelle opened this issue Jan 16, 2025 · 7 comments
Assignees
Labels
🐛 bug Something isn't working

Comments

@BorghildSelle
Copy link
Contributor

Image

Text is not white and have enough contrast, style and look improvements necessary

@BorghildSelle BorghildSelle added the 🐛 bug Something isn't working label Jan 16, 2025
@NickHaggerty1
Copy link
Collaborator

Hey, this also doesn't match the text or the image that is created in the studio

@NickHaggerty1
Copy link
Collaborator

Image

@NickHaggerty1
Copy link
Collaborator

Commented on #2828 too but adding here... Another visual issue on the 404 template: Currently the hyperlink is green and goes small in size (maybe replicating the menu?). Could you adjust this to reflect our styling for hyperlinks? Normal size/bold/dark text as per sketch above

@padms padms self-assigned this Mar 11, 2025
@padms
Copy link
Contributor

padms commented Mar 14, 2025

@NickHaggerty1 @meols This is fixed along with the content releases, now every document can be previewed in draft /published / release versions .

@NickHaggerty1
Copy link
Collaborator

@padms @BorghildSelle Thanks, seems to good go. Couple of small things as demoed in the meeting:

  1. The hyperlink text is smaller that than the main body text. Should be the same size.
  2. Is if possible to make the desktop height of the image bigger? Now its quite narrow.

@padms
Copy link
Contributor

padms commented Mar 26, 2025

@NickHaggerty1 This is ready for another quick round of review with the fix.

@NickHaggerty1
Copy link
Collaborator

@padms Great thanks. Good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants