Skip to content

Conversation

@HakonSohoel
Copy link
Contributor

@HakonSohoel HakonSohoel commented Sep 23, 2025

Issue
Intended to solve #11829, but abandoned

Approach
Added logic to fix plot color to ensemble order, including unselected ensembles.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 23, 2025

CodSpeed Performance Report

Merging #11887 will not alter performance

Comparing HakonSohoel:Fix-plot-color-to-order (92cb232) with main (71fe688)

Summary

✅ 22 untouched

@HakonSohoel HakonSohoel changed the title WIP: Fix color to ensemble sort order Fix color to ensemble sort order Sep 23, 2025
@HakonSohoel HakonSohoel force-pushed the Fix-plot-color-to-order branch from 9ded3b4 to 57f2d92 Compare September 23, 2025 14:43
@HakonSohoel HakonSohoel force-pushed the Fix-plot-color-to-order branch from 57f2d92 to 92cb232 Compare September 24, 2025 14:16
@HakonSohoel
Copy link
Contributor Author

Abandoned this option. Found a more elegant solution with PR #12036

@HakonSohoel HakonSohoel closed this Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant