Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate that the motd is utf8 #2228

Open
slingamn opened this issue Mar 12, 2025 · 1 comment
Open

validate that the motd is utf8 #2228

slingamn opened this issue Mar 12, 2025 · 1 comment
Milestone
v2.16

Comments

@slingamn
Copy link
Member

We got a bug report about this; it seems like Ergo will accept a non-UTF8 motd file and then attempt to serve it to text websocket clients, causing disconnection. if EnforceUTF8 is enabled then we should check utf8.Valid on the motd lines.
@slingamn slingamn added this to the v2.16 milestone Mar 12, 2025
@KlaasT
Copy link

KlaasT commented Mar 15, 2025

If you need something to test I can send you my motd per email as that one causes the websocket to disconnect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.16
Development

No branches or pull requests
2 participants
@slingamn @KlaasT