Enable custom "select store" view.#72
Open
z7ealth wants to merge 2 commits into
Open
Conversation
Enables to show a custom "select store" view when user access the application outside Shopify.
Added custom_select_store option to config
ericdude4
reviewed
Sep 3, 2024
Owner
ericdude4
left a comment
ericdude4
left a comment
There was a problem hiding this comment.
Thank you for your PR! I've left a comment, interested in your thoughts.
| end | ||
|
|
||
| defp respond_invalid(conn) do | ||
| web_module = get_web_module(Application.get_env(:shopifex, :custom_select_store, false)) |
Owner
There was a problem hiding this comment.
instead of introducing this extra flag in the config, I wonder if we can detect the presence of a "select-store.html" template within the web_module, if the web_module is provided? If the web_module is provided in the config and a select-store.html is not present, we should fall back to the Shopifex select-store.html.
Think this is possible?
Author
There was a problem hiding this comment.
Oh, ok ok, sounds like a better approach. I'll work on it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables to show a custom "select store" view when user access the application outside Shopify.