Skip to content

Downloader fixes #18180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
anacrolix wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Downloader fixes #18180

anacrolix wants to merge 3 commits into from
+309 −166

Conversation

@anacrolix
Copy link
Contributor

@anacrolix anacrolix commented Dec 5, 2025

  • Fixes panic using --downloader.verify from --downloader.verify asserts for already completed files #18165.
  • Pulls the full fixes from anacrolix/torrent master from [3.3] Torrent client fixes #18179. That's the announce thrashing and some poor logging. Also includes some small performance improvements.
  • Updates the Downloader tests since the final PR, and fixes all the issues they uncovered:
    • Unsynchronized download requests.
    • Not handling mismatched infohashes or names (which happens in the tests)
    • BuildTorrentIfNeed would silently ignore missing data files.
  • Handles some cases where Delete and Download might be called at the same time.

@anacrolix anacrolix requested a review from shohamc1 December 6, 2025 03:57
@anacrolix anacrolix force-pushed the anacrolix/downloader-misc branch from c65626a to 18ad7fc Compare December 6, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shohamc1 shohamc1 Awaiting requested review from shohamc1

@AskAlexSharov AskAlexSharov Awaiting requested review from AskAlexSharov AskAlexSharov will be requested when the pull request is marked ready for review AskAlexSharov is a code owner

@sudeepdino008 sudeepdino008 Awaiting requested review from sudeepdino008 sudeepdino008 will be requested when the pull request is marked ready for review sudeepdino008 is a code owner

@Giulio2002 Giulio2002 Awaiting requested review from Giulio2002 Giulio2002 will be requested when the pull request is marked ready for review Giulio2002 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anacrolix