Skip to content

Get rid of GNU Grep dependency #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erikw opened this issue Apr 19, 2025 · 0 comments · Fixed by #472
Open

Get rid of GNU Grep dependency #467

erikw opened this issue Apr 19, 2025 · 0 comments · Fixed by #472
Labels
volunteer_needed Please sign up to fix!

Comments

@erikw
Copy link
Owner

erikw commented Apr 19, 2025

Inspired by #466 it's a good idea to not have code using GNU Grep specific options like the convenient -P swithc, as systems like *BSDs and macOS comes with a simpler (bsd) grep not supporting these options.

Find all usages of grep and rewrite to use only standard tools.

Volunteer needed!

The remaining usages needs a volunteer can only be fixed by someone who runs Linux and uses Spotify native client. Please make a PR for above similar to #472 i.e. use simpler POSIX syntax for the regex instead of -P perl syntax, or a different tool like awk or such.

@erikw erikw changed the title Get rid of GNU Grep dependency [Volunteer needed] Get rid of GNU Grep dependency Apr 29, 2025
erikw added a commit that referenced this issue Apr 29, 2025
Instead of spending time fix old code, remove it as it is unlikely to still be
used. If you in fact use this, please ping me and I'll add it back :).

Relates to #467
@erikw erikw reopened this Apr 29, 2025
@erikw erikw added the volunteer_needed Please sign up to fix! label Apr 29, 2025
@erikw erikw changed the title [Volunteer needed] Get rid of GNU Grep dependency Get rid of GNU Grep dependency Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
volunteer_needed Please sign up to fix!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant