fix(ts): dependency to not resolve using tsconfig paths (#13)

Author: privatenumber

package.json

@@ -33,7 +33,7 @@
 	},
 	"dependencies": {
 		"@esbuild-kit/core-utils": "^2.0.0",
-		"get-tsconfig": "^4.0.0"
+		"get-tsconfig": "^4.0.5"
 	},
 	"devDependencies": {
 		"@pvtnbr/eslint-config": "^0.22.0",

pnpm-lock.yaml

@@ -1,3 +1,4 @@
+import path from 'path';
 import fs from 'fs';
 import Module from 'module';
 import {
@@ -11,6 +12,7 @@ import { getTsconfig, createPathsMatcher } from 'get-tsconfig';
 
 const isPathPattern = /^\.{0,2}\//;
 const isTsFilePatten = /\.[cm]?tsx?$/;
+const nodeModulesPath = `${path.sep}node_modules${path.sep}`;
 
 const tsconfig = getTsconfig();
 const tsconfigRaw = tsconfig?.config;
@@ -112,8 +114,12 @@ Module._resolveFilename = function (request, parent, isMain, options) {
 
 	if (
 		tsconfigPathsMatcher
+
 		// bare specifier
 		&& !isPathPattern.test(request)
+
+		// Dependency paths should not be resolved using tsconfig.json
+		&& !parent?.filename.includes(nodeModulesPath)
 	) {
 		const possiblePaths = tsconfigPathsMatcher(request);
 		for (const possiblePath of possiblePaths) {

src/index.ts

@@ -0,0 +1 @@
+require('resolve-current-directory');

tests/fixtures/tsconfig/dependency-resolve-current-directory.ts

@@ -0,0 +1 @@
+require('should-not-resolve-baseUrl');

tests/fixtures/tsconfig/dependency-should-not-resolve-baseUrl.ts

@@ -0,0 +1 @@
+require('should-not-resolve-paths');

tests/fixtures/tsconfig/dependency-should-not-resolve-paths.ts

@@ -0,0 +1 @@
+console.log('Should not run');

tests/fixtures/tsconfig/node_modules/resolve-current-directory/lib/file.js

@@ -1 +1 @@
-export default 'resolved';
+export default 'resolve-target';

tests/fixtures/tsconfig/node_modules/resolve-current-directory/lib/index.js

@@ -1 +1 @@
-export default 'resolved';
+export default 'nested-resolve-target';

tests/fixtures/tsconfig/node_modules/resolve-current-directory/package.json

@@ -10,33 +10,56 @@ export default testSuite(async ({ describe }, node: NodeApis) => {
 			expect(nodeProcess.stdout).toBe('div null hello world\nnull null goodbye world');
 		});
 
-		describe('paths', ({ test }) => {
+		describe('paths', ({ test, describe }) => {
 			test('resolves baseUrl', async () => {
 				const nodeProcess = await node.load('./src/base-url.ts', {
 					cwd: './tsconfig',
 				});
-				expect(nodeProcess.stdout).toBe('resolved');
+				expect(nodeProcess.stdout).toBe('resolve-target');
 			});
 
 			test('resolves paths exact match', async () => {
 				const nodeProcess = await node.load('./src/paths-exact-match.ts', {
 					cwd: './tsconfig',
 				});
-				expect(nodeProcess.stdout).toBe('resolved');
+				expect(nodeProcess.stdout).toBe('resolve-target');
 			});
 
 			test('resolves paths prefix', async () => {
 				const nodeProcess = await node.load('./src/paths-prefix-match.ts', {
 					cwd: './tsconfig',
 				});
-				expect(nodeProcess.stdout).toBe('resolved');
+				expect(nodeProcess.stdout).toBe('nested-resolve-target');
 			});
 
 			test('resolves paths suffix', async () => {
 				const nodeProcess = await node.load('./src/paths-suffix-match.ts', {
 					cwd: './tsconfig',
 				});
-				expect(nodeProcess.stdout).toBe('resolved');
+				expect(nodeProcess.stdout).toBe('nested-resolve-target');
+			});
+
+			describe('dependency', ({ test }) => {
+				test('resolve current directory', async () => {
+					const nodeProcess = await node.load('./dependency-resolve-current-directory', {
+						cwd: './tsconfig',
+					});
+					expect(nodeProcess.stdout).toBe('resolved');
+				});
+
+				test('should not resolve baseUrl', async () => {
+					const nodeProcess = await node.load('./dependency-should-not-resolve-baseUrl', {
+						cwd: './tsconfig',
+					});
+					expect(nodeProcess.stdout).toBe('resolved');
+				});
+
+				test('should not resolve paths', async () => {
+					const nodeProcess = await node.load('./dependency-should-not-resolve-paths', {
+						cwd: './tsconfig',
+					});
+					expect(nodeProcess.stdout).toBe('resolved');
+				});
 			});
 		});
 	});