-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respecting the optional scope in Conventional Commits #179
Comments
Yeah, unfortunately it needs to be this way for now. It’s not just that the bot needs to change, it’s the release process in general that doesn’t understand conventional commits scopes. We are looking at some alternatives but for now we can’t support scopes in commit messages. |
Why not just use Commitlint would also state exactly what's wrong with the commit message. The current process is kind of opaque and was a head scratcher for me since I write conventional commit messages every day, so my commit message adhered to the spec but I had no idea what eslint-github-bot didn't like about it. |
@jedwards1211 please see the preceding comment. It’s our whole tooling system that would need to change, not just the bot commit check. |
* docs: note commit messages don't support scope eslint/eslint-github-bot#179 (comment) * Update docs/src/developer-guide/contributing/pull-requests.md Co-authored-by: Nicholas C. Zakas <[email protected]>
The Pull Request section of the ESLint documentation explicitly mentions that
The convention for Conventional Commits is
However, ESLint Bot doesn't recognize the scope part of the commit message, so contributors who are already used to Conventional Commits have to modify the commit message to remove the scope part and recommit.
This caused some trouble. ESLint uses, but not exclusively, Conventional Commits
Footnotes
Pull Requests - ESLint - Pluggable JavaScript Linter ↩
The text was updated successfully, but these errors were encountered: