Merge pull request #771 from RubenKelevra/bugfix/sccb-max-devices-oob

me-no-dev · web-flow · commit f0814e695a4a · 2025-07-17T17:02:07.000+03:00
sccb-ng: fix off-by-one device capacity check to prevent overflow
diff --git a/driver/sccb-ng.c b/driver/sccb-ng.c
@@ -80,7 +80,7 @@ int SCCB_Install_Device(uint8_t slv_addr)
     esp_err_t ret;
     i2c_master_bus_handle_t bus_handle;
 
-    if (device_count > MAX_DEVICES)
+    if (device_count >= MAX_DEVICES)
     {
         ESP_LOGE(TAG, "cannot add more than %d devices", MAX_DEVICES);
         return ESP_FAIL;

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ int SCCB_Install_Device(uint8_t slv_addr)`
`80`	`80`	`esp_err_t ret;`
`81`	`81`	`i2c_master_bus_handle_t bus_handle;`
`82`	`82`
`83`		`- if (device_count > MAX_DEVICES)`
	`83`	`+ if (device_count >= MAX_DEVICES)`
`84`	`84`	`{`
`85`	`85`	`ESP_LOGE(TAG, "cannot add more than %d devices", MAX_DEVICES);`
`86`	`86`	`return ESP_FAIL;`