diff --git a/apps/setting/ChangeLog b/apps/setting/ChangeLog index 0f88be9dd9..17098b069d 100644 --- a/apps/setting/ChangeLog +++ b/apps/setting/ChangeLog @@ -86,3 +86,4 @@ of 'Select Clock' 0.75: Restore previous menu's scroll positions 0.76: Add altitude calibration menu (and update README after menu changed) 0.77: Save altitude calibration when user exits via reset +0.78: Fix menu scroll restore on BangleJS1 diff --git a/apps/setting/metadata.json b/apps/setting/metadata.json index b37534577c..4940b5f70c 100644 --- a/apps/setting/metadata.json +++ b/apps/setting/metadata.json @@ -1,7 +1,7 @@ { "id": "setting", "name": "Settings", - "version": "0.77", + "version": "0.78", "description": "A menu for setting up Bangle.js", "icon": "settings.png", "tags": "tool,system", diff --git a/apps/setting/settings.js b/apps/setting/settings.js index 8303c8c253..3d7f35cd80 100644 --- a/apps/setting/settings.js +++ b/apps/setting/settings.js @@ -27,7 +27,8 @@ function pushMenu(menu) { function restoreMenu(menu) { // equivalent to pushMenu(null); popMenu(menu); if(!menu[""]) menu[""] = {}; - menu[""].scroll = menuScroller.scroll; + if(menuScroller) // may be undefined on BangleJS1 + menu[""].scroll = menuScroller.scroll; menuScroller = E.showMenu(menu).scroller; }