Adding missed call notifications in Gadgetbridge

[umpfel]

I added/copied the notification for missed calls from the lenovo watch x (WatchXPlusDeviceSupport) to the Bangle.js.
Would you mind adding this to the official Bangle.js Gadgetbridge?

missed_call_notification.patch.txt

[thyttan]

Interesting!

Just a FYI that if you contribute the code in a PR to the gadgetbridge repo at https://codeberg.org/Freeyourgadget/Gadgetbridge , it will also end up in the Bangle.js Gadgetbridge flavor. And with credits to you! :)

[umpfel]

I created a branch here: https://codeberg.org/umpfel/Gadgetbridge/commit/aa2c885893f933cb25be0fff8cdecb871ff4158f
I just wanted to check if you agree with these changes. If all looks good, I'll go ahead and create a pull request! :)

[thyttan]

I built it and am running your branch on my phone. The setting worked to enable/disable the feature for me. So looks good to me! Please go ahead! :)

For potential future work - it could be cool to be able to trigger a call back from the watch notification!

[gfwilliams]

Great! Thanks for this - looks good to me!

[fanoush]

maybe the string constant value should start with "pref_banglejs_" too to possibly not conflict when someone picks same name, this was probably the idea why they all start like this

public static final String PREF_BANGLEJS_ACTIVITY_FULL_SYNC_STOP = "pref_banglejs_activity_full_sync_stop";
+public static final String PREF_BANGLEJS_NOTIFICATION_MISSED_CALL_ENABLE = "pref_notification_enable_missed_call";

[ps-igel]

@gfwilliams Sorry to hijack this thread, I was just curious: how long do you think it takes you to create a new version of Gadgetbridge? I'm asking because they integrated new functions for the CMF Watch Pro 2 in the main "branch".

Having a CMF watch and Bangle.JS 1/2 I'd much prefer to only have one app running instead of two (Gadgetbridge and Banglejs-flavored Gadgetbridge).

[thyttan]

Is using nightly builds an option for you? They have all the latest stuff.

• https://www.espruino.com/Gadgetbridge#how-to-set-up
• https://freeyourgadget.codeberg.page/fdroid/repo/

[gfwilliams]

It feels like it'd be nice to wait until @umpfel's work is merged in before doing a new release?

But after that I can try and get one out...

[thyttan]

They are merged in master and in nightlies: https://codeberg.org/Freeyourgadget/Gadgetbridge/pulls?q=&type=all&sort=&state=all&labels=&milestone=0&project=0&assignee=0&poster=294512&fuzzy=true&archived=false

But I don't think there's any rush to release on play store since @ps-igel got the nightly working on their phone.

[thyttan]

I also heard a rumor from José Rebelo that he's hoping to get some extra data exporting functionality in soon. So may be worth waiting for.

Edit, link: https://codeberg.org/Freeyourgadget/Gadgetbridge/pulls/4542#issuecomment-3143933

[gfwilliams]

Ok, nice - thanks! And actually I spotted a PR in Gadgetbridge for DND syncing. Once that goes in it'd be awesome to get it in for Bangle.js too - I feel like that'd make a lot of people very happy

[ps-igel]

@thyttan In theory yes, but in Android 15 it is not possible to give all permission the apps needs to run properly if it was installed using the apk. Needs to installed via play store.

[thyttan]

That's not true on my phone at least - I also have 15. But you need to know where to allow restricted permissions. The three dots in top right corner of app info page I believe.

[ps-igel]

Thanks for mentioning. 👍
I swear I tried this and couldn't find the three dots or it somehow didn't work on my Pixel 7. Just tried again and it indeed works.

[thyttan]

You're welcome - I think I experienced something similar!