Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No padding in edit mode #47

Closed
sdeleuze opened this issue Nov 7, 2020 · 8 comments
Closed

No padding in edit mode #47

sdeleuze opened this issue Nov 7, 2020 · 8 comments

Comments

@sdeleuze
Copy link

sdeleuze commented Nov 7, 2020

The lack of padding in edit mode makes it pretty difficult to go at the beginning of a line on iOS, and makes the cursor position/first letter difficult to see in the webapp.

image

@tasn
Copy link
Member

tasn commented Nov 8, 2020

There is padding in edit mode (10px wide). Could you please try opening the notes app in incognito mode to make sure you have the latest version and it's not just a cache issue?

@sdeleuze
Copy link
Author

sdeleuze commented Nov 8, 2020

I opened the app in incognito mode, but the issue is the same, and it also impact the mobile app on iPhone.
I am using Brave (so Chrome based).

If that can help, see below a screen capture with devtools in view mode where I can see the padding:
image

But in edit mode you can see that no padding seems to be defined:
image

@tasn tasn closed this as completed in 5a3e81d Nov 8, 2020
@tasn
Copy link
Member

tasn commented Nov 8, 2020

Oops, you are right. it's a recent regression and I just haven't noticed it on Android as there's already decent padding there by default.

@tasn
Copy link
Member

tasn commented Nov 8, 2020

Just deployed a new version.

@sdeleuze
Copy link
Author

sdeleuze commented Nov 8, 2020

Thanks for the quick fix.

@tasn
Copy link
Member

tasn commented Nov 8, 2020

Does it indeed work (on the web)?

@sdeleuze
Copy link
Author

sdeleuze commented Nov 8, 2020

Yeah there is now left and right padding on the webapp, thanks.

image

May I suggest to specify a top and bottom 10px padding as well? That would be consistent with the view mode, would look IMO better and I am not sure the current 0px is defined on purpose.

tasn added a commit that referenced this issue Nov 8, 2020
Again, this was already there for Android, but missing for the rest.

Fixes #47.
@tasn
Copy link
Member

tasn commented Nov 8, 2020

Fixed that one too. Thanks!
The confusing thing is that on Android (where I'm testing) there is default padding, so I didn't notice it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants