[OP Stack Deployment] Deployment reverted by create2

[Aminechakr]

Did you check the documentation?

• Yes

Did you check for duplicate questions?

• Yes

Issue Description

While trying to deploy a rollup on L1 Sepolia using op-stack 1.9.5, we get reverted by create2 and we're not sure what's the reason. Salt was mentioned as a potential issue, how can we check if it's the case?

Logs

op_node_init-1  | == Logs ==
op_node_init-1  |   Writing artifact to /root/optimism/packages/contracts-bedrock/deployments/11155111-deploy.json
op_node_init-1  |   Connected to network with chainid 11155111
op_node_init-1  |   Commit hash:  (5662448279e4fb16e073e00baeb6e458b12a59b2
op_node_init-1  |   DeployConfig: reading file ./deployments/2819389/.deploy
op_node_init-1  |   Deploying a fresh OP Stack including SuperchainConfig
op_node_init-1  |   start of L1 Deploy!
op_node_init-1  |   Setting up Superchain
op_node_init-1  |   Saving SuperchainProxyAdmin: 0xdaE97900D4B184c5D2012dcdB658c008966466DD
op_node_init-1  |   Saving SuperchainConfigProxy: 0xDc82c0362A241Aa94d53546648EACe48C9773dAa
op_node_init-1  |   Saving SuperchainConfig: 0x238213078DbD09f2D15F4c14c02300FA1b2A81BB
op_node_init-1  |   Saving ProtocolVersionsProxy: 0x856e75e9c0Da547F9753c17746D6cc139b668e5c
op_node_init-1  |   Saving ProtocolVersions: 0xd85BdcdaE4db1FAEB8eF93331525FE68D7C8B3f0
op_node_init-1  |   Running chain assertions on the ProtocolVersions proxy at 0x856e75e9c0Da547F9753c17746D6cc139b668e5c
op_node_init-1  |   Running chain assertions on the SuperchainConfig proxy at 0xDc82c0362A241Aa94d53546648EACe48C9773dAa
op_node_init-1  |   Running chain assertions on the ProtocolVersions implementation at 0xd85BdcdaE4db1FAEB8eF93331525FE68D7C8B3f0
op_node_init-1  |   Running chain assertions on the SuperchainConfig implementation at 0x238213078DbD09f2D15F4c14c02300FA1b2A81BB
op_node_init-1  |   Deploying implementations
op_node_init-1  | Error: script failed: revert: DeployImplementations: create2 failed

Additional Information

No response

Feedback

No response

[Chomtana]

Have you set IMPL_SALT in env variable?

You can echo $IMPL_SALT before running deployment script to see if the salt has been set

[Aminechakr]

Yes I have, it's already set. I double-checked with the echo command right before the deployment step. I made sure that the ADMIN_PRIVATE_KEY was changed.

[Aminechakr]

I don't know if this is relevant but I notice this error in the contracts deployment logs:

op_node_init-1 | │ ├─ [0] VM::parseTomlAddress("<stringified TOML>", ".releases[\"dev\"].dispute_game_factory.address") [staticcall] op_node_init-1 | │ │ └─ ← [Revert] vm.parseTomlAddress: failed parsing TOML: TOML parse error at line 1, column 1 op_node_init-1 | | op_node_init-1 | 1 | /root/optimism/packages/contracts-bedrock/test/fixtures/standard-versions.toml op_node_init-1 | | ^ op_node_init-1 | invalid key

[jsvisa]

@Aminechakr I think the error was here https://github.com/ethereum-optimism/optimism/blob/5662448279e4fb16e073e00baeb6e458b12a59b2/packages/contracts-bedrock/scripts/deploy/DeployImplementations.s.sol#L1029-L1034

    function deployBytecode(bytes memory _bytecode, bytes32 _salt) public returns (address newContract_) {
        assembly ("memory-safe") {
            newContract_ := create2(0, add(_bytecode, 0x20), mload(_bytecode), _salt)
        }
        require(newContract_ != address(0), "DeployImplementations: create2 failed");
    }

Could you please rerun forge with -vvvv to see if there are more logs?

[Aminechakr]

@jsvisa There isn't much additional details with debug, logs stays almost the same.

[jsvisa]

It's wired, could you please paste the full command/steps used to deploy the op-stack, I'll try to reproeuce it.

[jsvisa]

After some digging, I think this was becasue the salt was not set in v1.9.5, so the value is 0x000..., you can print the salt in the deployBytecode function, https://github.com/jsvisa/optimism/blob/73238193ac4881c9a4bc3f2c6ca66295605a4180/packages/contracts-bedrock/scripts/deploy/DeployImplementations.s.sol#L1029.

But in the current latest develop branch, the salt was hardcoded into another value https://github.com/ethereum-optimism/optimism/blob/a10fd5259a3af9a465955b035e16f516327d51d5/packages/contracts-bedrock/scripts/deploy/DeployImplementations.s.sol#L440-L441

So if you still need to deploy v1.9.5, I think you can manually set the salt, like ethereum-optimism/optimism@7323819

[Chomtana]

I have no idea what cause this.

Can you try v1.9.0 or try this docker compose to deploy OP Stack: https://github.com/upnodedev/opstack-compose/blob/main/.env.example

[opfocus]

If you have an acceptable answer, please mark it as the answer and close the question. If you're still facing issues, please add a comment.