Skip to content

Deprecate InfoBanner, migrate usage to ui/alert components #15407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 of 2 tasks
wackerow opened this issue May 6, 2025 · 2 comments · May be fixed by #15414
Open
1 of 2 tasks

Deprecate InfoBanner, migrate usage to ui/alert components #15407

wackerow opened this issue May 6, 2025 · 2 comments · May be fixed by #15414
Assignees
@JoeChenJ
Labels
design All the issues related to design should use this tag good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help

Comments

@wackerow
Copy link
Member

wackerow commented May 6, 2025 •
edited
Loading

Describe the issue

The InfoBanner component is out of sync with our design system. PR #13986 was an attempt to update, but it got lost in the shuffle and the codebase has since updated quite a bit leaving that one with quite a few merge conflicts.

Requesting we try again to deprecate all instances of InfoBanner and replace with usage of the Alert component (using variants and tailwind classes), as demonstrated in #13986. That branch should be available for reference as needed.

Expected behavior

InfoBanner component should be removed from codebase, with all instances refactored to use Alert component instead

Would you like to work on this issue?

  • Yes
  • No
@wackerow wackerow added help wanted Extra attention is needed or someone is needed to help good first issue Good item to try if you're new to contributing design All the issues related to design should use this tag labels May 6, 2025
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label May 6, 2025
@wackerow wackerow mentioned this issue May 6, 2025
Closed
@isabelladebrito isabelladebrito removed the needs triage 📥 This issue needs triaged before being worked on label May 6, 2025
@JoeChenJ
Copy link
Contributor

JoeChenJ commented May 7, 2025

@wackerow I would like to work on this!

@JoeChenJ JoeChenJ linked a pull request May 8, 2025 that will close this issue
Open
@Arya-A-Nair
Copy link

@isabelladebrito would like to work on it, if no one is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoeChenJ JoeChenJ

Labels
design All the issues related to design should use this tag good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: migrate usage of InfoBanner to ui/alert JoeChenJ/ethereum-org-website
4 participants
@wackerow @Arya-A-Nair @isabelladebrito @JoeChenJ