You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Transaction RPC responses have v and gasPrice fields marked as deprecated, thus they are not required. But the generated test fixtures for Hive tests do have them. So any client that does not return these fields will fail the tests.
Such behavior creates confusion regarding what should be considered "spec compliant". While it makes sense to keep these fields for backward compatibility for legacy RPC consumers, it also makes it hard to understand how to approach such discrepancies.
I see a few solutions to address this issue:
filter out non-required fields on test fixture generation and/or hive tests
mark these fields as required
Which IMO not ideal. Were there any discussions in this regard?
The text was updated successfully, but these errors were encountered:
Transaction RPC responses have
v
andgasPrice
fields marked as deprecated, thus they are not required. But the generated test fixtures for Hive tests do have them. So any client that does not return these fields will fail the tests.Such behavior creates confusion regarding what should be considered "spec compliant". While it makes sense to keep these fields for backward compatibility for legacy RPC consumers, it also makes it hard to understand how to approach such discrepancies.
I see a few solutions to address this issue:
Which IMO not ideal. Were there any discussions in this regard?
The text was updated successfully, but these errors were encountered: