Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hive: Non-required field failing the hive tests #631

Open
brbrr opened this issue Feb 20, 2025 · 0 comments
Open

Hive: Non-required field failing the hive tests #631

brbrr opened this issue Feb 20, 2025 · 0 comments

Comments

@brbrr
Copy link

brbrr commented Feb 20, 2025

Transaction RPC responses have v and gasPrice fields marked as deprecated, thus they are not required. But the generated test fixtures for Hive tests do have them. So any client that does not return these fields will fail the tests.

Such behavior creates confusion regarding what should be considered "spec compliant". While it makes sense to keep these fields for backward compatibility for legacy RPC consumers, it also makes it hard to understand how to approach such discrepancies.

I see a few solutions to address this issue:

  • filter out non-required fields on test fixture generation and/or hive tests
  • mark these fields as required

Which IMO not ideal. Were there any discussions in this regard?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant