From 12d30670899d491195ec577975419d5037a72fae Mon Sep 17 00:00:00 2001 From: Matthieu Vachon Date: Wed, 8 Jan 2025 13:52:54 -0500 Subject: [PATCH 1/3] Document `OnCodeChange` now being called in SelfDestruct --- core/tracing/CHANGELOG.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/core/tracing/CHANGELOG.md b/core/tracing/CHANGELOG.md index e8aa3a9e2ebe..7722a77fb75b 100644 --- a/core/tracing/CHANGELOG.md +++ b/core/tracing/CHANGELOG.md @@ -9,6 +9,14 @@ All notable changes to the tracing interface will be documented in this file. - `GasChangeReason` has been extended with the following reasons which will be enabled only post-Verkle. There shouldn't be any gas changes with those reasons prior to the fork. - `GasChangeWitnessContractCollisionCheck` flags the event of adding to the witness when checking for contract address collision. +## [v1.14.12] + +This release contains a change in behavior for `OnCodeChange` hook. + +### `OnCodeChange` change + +The `OnCodeChange` is now called when `StateDB#SelfDestruct` or `StateDB#SelfDestruct6780` is invoked, which happens when a contract self destruct itself. Previously, no code change was emitted on such occasions. + ## [v1.14.4] This release contained only minor extensions to the tracing interface. From c02f846b0b7862027e3fd9af669df85f2e478513 Mon Sep 17 00:00:00 2001 From: Matthieu Vachon Date: Thu, 9 Jan 2025 09:16:50 -0500 Subject: [PATCH 2/3] Adjusted description of change. --- core/tracing/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/tracing/CHANGELOG.md b/core/tracing/CHANGELOG.md index 7722a77fb75b..4002a9a928a2 100644 --- a/core/tracing/CHANGELOG.md +++ b/core/tracing/CHANGELOG.md @@ -15,7 +15,7 @@ This release contains a change in behavior for `OnCodeChange` hook. ### `OnCodeChange` change -The `OnCodeChange` is now called when `StateDB#SelfDestruct` or `StateDB#SelfDestruct6780` is invoked, which happens when a contract self destruct itself. Previously, no code change was emitted on such occasions. +The `OnCodeChange` hook is now called when `StateDB#SelfDestruct` is called or when `StateDB#SelfDestruct6780` is called and the contract is actually destroyed. Previously, no code change was emitted on such occasions. ## [v1.14.4] From d466d7976973f7ca09310511975c829c965eafe1 Mon Sep 17 00:00:00 2001 From: Sina M <1591639+s1na@users.noreply.github.com> Date: Wed, 15 Jan 2025 15:15:18 +0100 Subject: [PATCH 3/3] Update core/tracing/CHANGELOG.md --- core/tracing/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/tracing/CHANGELOG.md b/core/tracing/CHANGELOG.md index 4002a9a928a2..270e0a30bf60 100644 --- a/core/tracing/CHANGELOG.md +++ b/core/tracing/CHANGELOG.md @@ -15,7 +15,7 @@ This release contains a change in behavior for `OnCodeChange` hook. ### `OnCodeChange` change -The `OnCodeChange` hook is now called when `StateDB#SelfDestruct` is called or when `StateDB#SelfDestruct6780` is called and the contract is actually destroyed. Previously, no code change was emitted on such occasions. +The `OnCodeChange` hook is now called when the code of a contract is removed due to a selfdestruct. Previously, no code change was emitted on such occasions. ## [v1.14.4]