Skip to content

[DRAFT] Fix unsat cache #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[DRAFT] Fix unsat cache #720

wants to merge 2 commits into from

Conversation

msooseth
Copy link
Collaborator

Description

Wow, UNSAT cache was not actually updated when checking equivalence.

TODO:

  • Check if we could have an unsat cache also for regular solving? Do we have it already?
  • Add a test-case that somehow checks for this working.

Checklist

  • tested locally
  • added automated tests
  • updated the docs
  • updated the changelog

@msooseth msooseth changed the title Fix unsat cache thanks to @blishko [DRAFT] Fix unsat cache thanks to @blishko Apr 29, 2025
@msooseth msooseth changed the title [DRAFT] Fix unsat cache thanks to @blishko [DRAFT] Fix unsat cache Apr 29, 2025
blishko
blishko reviewed Apr 29, 2025
View reviewed changes
@msooseth msooseth force-pushed the fixing-equiv-cache-update branch from cb287f4 to c332f3c Compare April 29, 2025 12:47
@msooseth msooseth force-pushed the fixing-equiv-cache-update branch from c332f3c to 0c739cb Compare April 29, 2025 13:32
@msooseth
Copy link
Collaborator Author

This works locally and is wrong when ran on the CI. My first guess would be some kind of race condition :S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blishko blishko blishko left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msooseth @blishko