Monorepo: Set "type": "module" in package.json files (default ESM internally) (#3494)

* Do a simple test and see what happens (Util) (npm i works, test:node works, lint works, docs do not work (maybe unrelated), examples work)

* Switch all other libraries over

* Move view specialized debug functionality out of trie src since debug module causes too much problem in this intense usage setup (not ESM ready)

* Trie import fixes

* VM example file extension renaming

* Fix VM examples

* Import fix

* Make the switch-over in tsconfig files

* Fix some new lint failures

* Bugfix (wrong import extension)

* Import file extension fixes

* Fix benchmarks

* Fix various import issues

* Remove duplicative node types and clean up references

---------

Co-authored-by: acolytec3 <[email protected]>

Author: holgerd77

config/tsconfig.json

@@ -3,8 +3,8 @@
     "sourceMap": true,
     "declaration": true,
     "declarationMap": true,
-    "module": "Node16",
-    "moduleResolution": "node",
+    "module": "NodeNext",
+    "moduleResolution": "NodeNext",
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
     "esModuleInterop": false,

config/tsconfig.prod.cjs.json

@@ -1,3 +1,7 @@
 {
-  "extends": "./tsconfig.json"
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "module": "Node16",
+    "moduleResolution": "node"
+  }
 }

config/tsconfig.prod.esm.json

@@ -1,6 +1,3 @@
 {
-  "extends": "./tsconfig.json",
-  "compilerOptions": {
-    "module": "esnext"
-  }
+  "extends": "./tsconfig.json"
 }

packages/block/package.json

@@ -16,7 +16,7 @@
   },
   "license": "MPL-2.0",
   "author": "mjbecze ([email protected])",
-  "type": "commonjs",
+  "type": "module",
   "main": "dist/cjs/index.js",
   "module": "dist/esm/index.js",
   "exports": {

packages/blockchain/package.json

@@ -16,7 +16,7 @@
   },
   "license": "MPL-2.0",
   "author": "mjbecze <[email protected]>",
-  "type": "commonjs",
+  "type": "module",
   "main": "dist/cjs/index.js",
   "module": "dist/esm/index.js",
   "exports": {

packages/blockchain/src/consensus/clique.ts

@@ -18,9 +18,8 @@ import type { Blockchain } from '../index.js'
 import type { Consensus, ConsensusOptions } from '../types.js'
 import type { Block, BlockHeader } from '@ethereumjs/block'
 import type { CliqueConfig } from '@ethereumjs/common'
-const { debug: createDebugLogger } = debugDefault
 
-const debug = createDebugLogger('blockchain:clique')
+const debug = debugDefault('blockchain:clique')
 
 // Magic nonce number to vote on adding a new signer
 export const CLIQUE_NONCE_AUTH = hexToBytes('0xffffffffffffffff')

packages/blockchain/src/consensus/ethash.ts

@@ -44,7 +44,7 @@ export class EthashConsensus implements Consensus {
   public async genesisInit(): Promise<void> {}
   public async setup({ blockchain }: ConsensusOptions): Promise<void> {
     this.blockchain = blockchain
-    this._ethash = new Ethash(this.blockchain.db as any)
+    this._ethash = new Ethash(this.blockchain!.db as any)
   }
   public async newBlock(): Promise<void> {}
 }

packages/blockchain/src/types.ts

@@ -1,4 +1,4 @@
-import type { Blockchain } from '.'
+import type { Blockchain } from './index.js'
 import type { Block, BlockHeader } from '@ethereumjs/block'
 import type { Common, ConsensusAlgorithm } from '@ethereumjs/common'
 import type { AsyncEventEmitter, DB, DBObject, GenesisState } from '@ethereumjs/util'

packages/blockchain/tsconfig.json

@@ -2,7 +2,6 @@
   "extends": "../../config/tsconfig.json",
   "include": ["src/**/*.ts", "src/**/*.json", "test/**/*.ts"],
   "compilerOptions": {
-    "types": ["node"],
     "typeRoots": ["node_modules/@types"]
   }
 }

packages/client/package.json

@@ -20,9 +20,9 @@
   },
   "license": "MPL-2.0",
   "author": "Vinay Pulim ([email protected])",
+  "type": "module",
   "main": "dist/esm/bin/cli.js",
   "types": "dist/esm/src/index.d.ts",
-  "type": "module",
   "bin": {
     "ethereumjs": "dist/esm/bin/cli.js"
   },