Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version create #16

Open
evanrs opened this issue Mar 27, 2016 · 0 comments
Open

Version create #16

evanrs opened this issue Mar 27, 2016 · 0 comments

Comments

@evanrs
Copy link
Owner

evanrs commented Mar 27, 2016

create receives the store to dispatch updates and return values selected from the namespace. This could have the unintended consequence of letting unrelated namespaces received updates out of band. In effect there is a shared object reference defeating immutability.

Solution

Updates should occur through an explicit call ns.update(), or through recreation on next render. create should guard for this and throw on calls to dispatch if versions are out of sync.

@evanrs evanrs changed the title Version ns.create Version namespace.create Mar 27, 2016
@evanrs evanrs changed the title Version namespace.create Version create Mar 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant