Invalid date-time fails validation

[tomsfernandez]

When using a date-time with a day that exceeds the max amount of days in a month like February 30th the validator doesn't fail.

I added this test to test/vanilla/src/main/resources/org/everit/json/schema/draft7/date-time.json

{
  "description": "only RFC3339 invalid date-time according to calendar rules",
  "data": "1963-02-30T00:00:00Z",
  "valid": false
}

[erosb]

@tomsfernandez are you sure you are at the right repo? This error description doesn't look any familiar. This library formats date-time validation errors like this:

json-schema/core/src/main/java/org/everit/json/schema/internal/TemporalFormatValidator.java

Line 36 in 440c9ef

return Optional.of(String.format("[%s] is not a valid %s. Expected %s", subject, formatName(), formatsAccepted));

[tomsfernandez]

@erosb Hi! I created a draft PR with the bug: #479. Of course I don't mean to merge it, I found it easier to show the case and how I ran it by showing the code.

[erosb]

Interesting. I can't see anything in RFC3339 that forbids this string, but still it is obviously stupid. You can raise a PR with a fix if you want and I'm happy to review. I won't have time to fix it on my own.

[tomsfernandez]

Sure! btw "5.7. Restrictions" of the RFC states what I pointed at in this issue.

[erosb]

Hello @tomsfernandez I released a new validator, it has better "date-time" support than this library. You can take a look if it better fits your needs.