Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest renaminginterpolate! to fill! #109

Closed
alex-s-gardner opened this issue Oct 25, 2022 · 2 comments · Fixed by #110
Closed

Suggest renaminginterpolate! to fill! #109

alex-s-gardner opened this issue Oct 25, 2022 · 2 comments · Fixed by #110

Comments

@alex-s-gardner
Copy link
Contributor

My intuition for interpolate! is a function that can retrieve geoarray values between exact indices. For this reason I would suggest renaming interpolate! to fill!.

@evetion
Copy link
Owner

evetion commented Oct 29, 2022

Hmm, fill! would be a better name, but it would be a breaking change. And this doesn't solve your implicit question, that you want a interpolate method that retrieves values by interpolation right? Would you have a preference, for the interpolation method?

@alex-s-gardner
Copy link
Contributor Author

I'm not in need of an interpolate method yet but I can see this as a basic tool that would need to be included with GeoArrays. I think changing interpolate! to fill! earlier than later would cause the least disruption if you agree that it's a needed change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants