Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should bbox return an Extent? #122

Closed
alex-s-gardner opened this issue Feb 6, 2023 · 3 comments · Fixed by #126
Closed

Should bbox return an Extent? #122

alex-s-gardner opened this issue Feb 6, 2023 · 3 comments · Fixed by #126

Comments

@alex-s-gardner
Copy link
Contributor

Should all of the bbox named tuples be changed to Extents?

@evetion
Copy link
Owner

evetion commented Feb 7, 2023

Yes it should, I should be eating my own dogfood.

@evetion
Copy link
Owner

evetion commented Feb 7, 2023

I think Extent is an improvement over the namedtuple (especially since we're adopting it in multiple places), but I'm still unhappy with it in terms of naming (is it x, or X, or should it be longitude). And is the (min, max) thing also (west, east) etc.

@evetion evetion mentioned this issue Mar 30, 2023
2 tasks
@evetion
Copy link
Owner

evetion commented Mar 31, 2023

In GeoArrays 0.8, GeoInterface.extent(::Geoarray) now returns an Extent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants