We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently, BBox is defined as Float64.
bbox::NamedTuple{(:min_x, :min_y, :max_x, :max_y),Tuple{Float64, Float64, Float64, Float64}})
This is mostly true, but BBox can also be Int64. Or a combination of them (each element can be either Int or Float). GeoArrays does not handle this.
GeoArrays
julia> GeoArrays.bbox_to_affine((10,10), (min_x=10, min_y=10, max_x=100, max_y=100)) ERROR: MethodError: no method matching bbox_to_affine(::Tuple{Int64, Int64}, ::NamedTuple{(:min_x, :min_y, :max_x, :max_y), NTuple{4, Int64}}) Closest candidates are: bbox_to_affine(::Tuple{Integer, Integer}, ::NamedTuple{(:min_x, :min_y, :max_x, :max_y), NTuple{4, Float64}})
The text was updated successfully, but these errors were encountered:
Agreed, this also should be fixed for a lot of other methods in the codebase.
Sorry, something went wrong.
Is it necessary to specify type?
Of course, it is beneficial, but if someone would try bbox with string or something else, errors will happen somewhere else 😀.
Successfully merging a pull request may close this issue.
Currently, BBox is defined as Float64.
This is mostly true, but BBox can also be Int64. Or a combination of them (each element can be either Int or Float).
GeoArrays
does not handle this.The text was updated successfully, but these errors were encountered: