Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set struct in concrete. #85

Merged
merged 3 commits into from
Jan 13, 2022
Merged

Set struct in concrete. #85

merged 3 commits into from
Jan 13, 2022

Conversation

evetion
Copy link
Owner

@evetion evetion commented Jan 12, 2022

Fixes #80

@evetion evetion marked this pull request as ready for review January 12, 2022 20:47
- '1.6'
- 'nightly'
- "1.6"
- "1.7"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "1", which is the latest "1.x"?

src/geoarray.jl Outdated
@@ -1,18 +1,19 @@
RealOrMissing = Union{Real,Union{Missing,Real}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be a const?

@evetion evetion merged commit 029d841 into master Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GeoArray isn't a concrete type
2 participants