Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$('body').height() is not necessarily correct #10

Open
mlb5000 opened this issue Feb 22, 2014 · 1 comment
Open

$('body').height() is not necessarily correct #10

mlb5000 opened this issue Feb 22, 2014 · 1 comment

Comments

@mlb5000
Copy link

mlb5000 commented Feb 22, 2014

When calculating the viewport bounds in scrolled, $('body').height() is used to calculate bodyHeight. However, with full document scrolling (at least in Chrome and Firefox) the body height can be much smaller than the document height.

Changing $('body').height to $(document).height worked for me.

@eviltrout
Copy link
Owner

I'd happily accept a PR to make this change, assuming it works well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants