Skip to content

flushing takes a while, but there's no indication it's happening #5

Description

@larswirzenius

vbig --flush --progress /dev/usb-device for an 8 gigabyte device fills the disk block cache quickly, and then takes quite a while to flush out the buffer to the device. While the flushing is happening, there is no indication that something is happening in the terminal from which I launched vbig. If I didn't know what's happening, I would've assumed somethings broken.

This would've been acceptable without --progress.

Suggestion: show "flushing" if --progress is used, similar to the "writing" and "verifying" messages. Obviously "flushing" doesn't need to how much remains to flush, since that's difficult to get from the kernel.

Related suggestion: open the output file with O_DIRECT, when writing, at least on Linux, to avoid a lengthy flushing wait. Possibly O_SYNC.

Metadata

Metadata

Assignees

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions