ruby 3.2.0 (#86)

* Upgrade to ruby 3.2

* Upgrade bundler

* Stop if non-zero exit code

* Update docker tag

* Use endless methods

* Fix rubocop workflow

* Fix tests workflow

* Add bundler cache

Author: ErikSchierboom

.github/workflows/rubocop.yml

@@ -5,24 +5,31 @@ on:
     branches: [main]
   pull_request:
     branches: [main]
+  workflow_dispatch:
 
 jobs:
   rubocop:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
 
     steps:
-      - uses: actions/checkout@v2
+      - name: Checkout code
+        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
 
       - name: Set up Ruby
-        uses: ruby/setup-ruby@a699edbce608a2c128dedad88e3b6a0e28687b3c
+        uses: ruby/setup-ruby@d4526a55538b775af234ba4af27118ed6f8f6677
         with:
-          ruby-version: 2.6.6
+          ruby-version: .ruby-version
 
       - name: Install gems
         run: |
-          gem install rubocop -v 1.7.0
-          gem install rubocop-minitest -v 0.11.0
-          gem install rubocop-performance -v 1.10.1
+          # Extract the exact versions of the rubocop gems from Gemfile.lock
+          rubocop_version=$(sed -n -E 's/^    rubocop \((.+)\)/\1/p' Gemfile.lock)
+          rubocop_performance_version=$(sed -n -E 's/^    rubocop-performance \((.+)\)/\1/p' Gemfile.lock)
+          rubocop_minitest_version=$(sed -n -E 's/^    rubocop-minitest \((.+)\)/\1/p' Gemfile.lock)
+
+          gem install rubocop -v $rubocop_version
+          gem install rubocop-performance -v $rubocop_performance_version
+          gem install rubocop-minitest -v $rubocop_minitest_version
 
       - name: Run Rubocop
         run: rubocop --except Metrics

.github/workflows/tests.yml

@@ -8,17 +8,16 @@ on:
 
 jobs:
   test:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
 
     steps:
-      # Checkout using GitHub's checkout action
-      - uses: actions/checkout@v2
+      - name: Checkout code
+        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
 
-      # Setup Ruby - this needs to match the version in the Gemfile
       - name: Set up Ruby
-        uses: ruby/setup-ruby@a699edbce608a2c128dedad88e3b6a0e28687b3c
+        uses: ruby/setup-ruby@d4526a55538b775af234ba4af27118ed6f8f6677
         with:
-          ruby-version: 2.6.6
+          ruby-version: .ruby-version
           bundler-cache: true
 
       # Setup code climate

.ruby-version

@@ -1 +1 @@
-2.6.6
+3.2.0

Dockerfile

@@ -1,4 +1,4 @@
-FROM amazon/aws-lambda-ruby
+FROM public.ecr.aws/lambda/ruby:3.2 AS build
 
 RUN yum install -y make gcc
 

Gemfile.lock

@@ -2,43 +2,51 @@ GEM
   remote: https://rubygems.org/
   specs:
     ast (2.4.2)
-    docile (1.3.2)
-    json (2.3.1)
-    mandate (0.3.0)
-    minitest (5.14.2)
+    docile (1.4.0)
+    json (2.7.1)
+    language_server-protocol (3.17.0.3)
+    mandate (2.2.0)
+    minitest (5.22.2)
     minitest-stub-const (0.6)
-    mocha (1.11.2)
-    parallel (1.20.1)
-    parser (3.0.0.0)
+    mocha (2.1.0)
+      ruby2_keywords (>= 0.0.5)
+    parallel (1.24.0)
+    parser (3.3.0.5)
       ast (~> 2.4.1)
-    rainbow (3.0.0)
-    rake (13.0.1)
-    regexp_parser (2.1.1)
-    rexml (3.2.4)
-    rubocop (1.11.0)
+      racc
+    racc (1.7.3)
+    rainbow (3.1.1)
+    rake (13.1.0)
+    regexp_parser (2.9.0)
+    rexml (3.2.6)
+    rubocop (1.60.2)
+      json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 3.0.0.0)
+      parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
-      rexml
-      rubocop-ast (>= 1.2.0, < 2.0)
+      rexml (>= 3.2.5, < 4.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.4.1)
-      parser (>= 2.7.1.5)
-    rubocop-minitest (0.11.0)
-      rubocop (>= 0.90, < 2.0)
-    rubocop-performance (1.10.1)
-      rubocop (>= 0.90.0, < 2.0)
-      rubocop-ast (>= 0.4.0)
-    ruby-progressbar (1.11.0)
+      unicode-display_width (>= 2.4.0, < 3.0)
+    rubocop-ast (1.30.0)
+      parser (>= 3.2.1.0)
+    rubocop-minitest (0.34.5)
+      rubocop (>= 1.39, < 2.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
+    rubocop-performance (1.20.2)
+      rubocop (>= 1.48.1, < 2.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
+    ruby-progressbar (1.13.0)
+    ruby2_keywords (0.0.5)
     simplecov (0.17.1)
       docile (~> 1.1)
       json (>= 1.8, < 3)
       simplecov-html (~> 0.10.0)
     simplecov-html (0.10.2)
-    unicode-display_width (2.0.0)
-    zeitwerk (2.4.2)
+    unicode-display_width (2.5.0)
+    zeitwerk (2.6.13)
 
 PLATFORMS
   ruby
@@ -57,4 +65,4 @@ DEPENDENCIES
   zeitwerk
 
 BUNDLED WITH
-   2.1.4
+   2.4.1

bin/rubocop-quick

@@ -1,4 +1,4 @@
 #!/bin/bash
 
-git diff --name-status --staged | grep '^[MA]' | grep -o '\s\+.*rb' | xargs bundle exec rubocop --except Metrics --auto-correct --format quiet --force-exclusion Gemfile && \
+git diff --name-status --staged | grep '^[MA]' | grep -o '\s\+.*rb' | xargs bundle exec rubocop --except Metrics --autocorrect --format quiet --force-exclusion Gemfile && \
 git diff --name-status --staged | grep '^[MA]' | grep -o '\s\+.*rb' | xargs git add

bin/run-in-docker.sh

@@ -15,6 +15,9 @@
 # Example:
 # ./bin/run-in-docker.sh csharp tests/csharp/simple.cs
 
+# Stop executing when a command returns a non-zero return code
+set -e
+
 # If any required arguments is missing, print the usage and exit
 if [[ $# -lt 2 ]]; then
     echo "usage: ./bin/run-in-docker.sh track-slug <path/to/source/code/> [path/to/output/directory/]"

bin/run.sh

@@ -3,4 +3,7 @@
 # Usage:
 # ./bin/run.sh two_fer ~/solution/ ~/output/
 
+# Stop executing when a command returns a non-zero return code
+set -e
+
 ruby bin/run.rb $1 $2 $3

lib/snippet_extractor.rb

@@ -6,7 +6,5 @@
 loader.setup
 
 module SnippetExtractor
-  def self.process_request(event:, context:)
-    ProcessRequest.(event, context)
-  end
+  def self.process_request(event:, context:) = ProcessRequest.(event, context)
 end

lib/snippet_extractor/basic/extract.rb

@@ -18,9 +18,7 @@ def call
         extracted_lines[0...10]
       end
 
-      def lines
-        code.lines
-      end
+      def lines = code.lines
     end
   end
 end

template.yaml

@@ -21,7 +21,7 @@ Resources:
             Path: /extract_snippet
             Method: post
     Metadata:
-      DockerTag: ruby2.7-v1
+      DockerTag: ruby3.2-v1
       DockerContext: ./
       Dockerfile: Dockerfile