PHPCodeSniffer config updated, code formatting fixed, PHPUnit fails related to test classes fixed (#103)

Author: katheroine

phpcs.xml

@@ -13,5 +13,5 @@
  <arg value="np"/>
 
  <rule ref="PSR1"/>
- <rule ref="PSR2"/>
+ <rule ref="PSR12"/>
 </ruleset>

src/file/File.php

@@ -142,8 +142,10 @@ private static function validatePathToWrite($path)
     {
         $directoryPath = dirname($path);
 
-        if ((file_exists($path) && !is_writable($path))
-        || (!file_exists($path) && !is_writable($directoryPath))) {
+        if (
+            (file_exists($path) && !is_writable($path))
+            || (!file_exists($path) && !is_writable($directoryPath))
+        ) {
             throw new FileException(
                 'File '
                 . $path

tests/unit_tests/coder_builder/CoderBuildingTraitTest.php

@@ -125,7 +125,7 @@ public function testBuildCoder($traitUsingClassObject, $expectedCoderClass)
      *
      * @return array
      */
-    public function traitUsingClassObjectsWithImproperPostfixProvider()
+    public static function traitUsingClassObjectsWithImproperPostfixProvider()
     {
         return array(
             array(new DummyClassFormat1Nocoder()),
@@ -141,7 +141,7 @@ public function traitUsingClassObjectsWithImproperPostfixProvider()
      *
      * @return array
      */
-    public function traitUsingClassObjectsWithImproperPrefixProvider()
+    public static function traitUsingClassObjectsWithImproperPrefixProvider()
     {
         return array(
             array(new FormatnotrecognizedDummyClassEncoder()),
@@ -155,7 +155,7 @@ public function traitUsingClassObjectsWithImproperPrefixProvider()
      *
      * @return array
      */
-    public function traitUsingClassObjectsWithImproperDataFormatProvider()
+    public static function traitUsingClassObjectsWithImproperDataFormatProvider()
     {
         return array(
             array(new DummyClassFormatNullEncoder()),
@@ -173,7 +173,7 @@ public function traitUsingClassObjectsWithImproperDataFormatProvider()
      *
      * @return array
      */
-    public function traitUsingClassObjectsAndBuiltCoderClassesProvider()
+    public static function traitUsingClassObjectsAndBuiltCoderClassesProvider()
     {
         return array(
             array(new DummyClassFormat1Encoder(), self::DUMMY_CODERS_NAMESPACE . '\Format1DataEncoder'),

tests/unit_tests/coders/data_coders/data_decoders/DataDecoderTest.php

@@ -151,7 +151,7 @@ public function testDecodeData($data)
      *
      * @return array
      */
-    public function dataFormatsAndResultsProvider()
+    public static function dataFormatsAndResultsProvider()
     {
         return array(
             array('format1', array('<FORMAT 1 DECODED DATA/>')),
@@ -165,7 +165,7 @@ public function dataFormatsAndResultsProvider()
      *
      * @return array
      */
-    public function dataProvider()
+    public static function dataProvider()
     {
         return array(
             array('apple'),

tests/unit_tests/coders/data_coders/data_encoders/DataEncoderTest.php

@@ -152,7 +152,7 @@ public function testEncodeData($data)
      *
      * @return array
      */
-    public function dataFormatsAndResultsProvider()
+    public static function dataFormatsAndResultsProvider()
     {
         return array(
             array('format1', '<FORMAT 1 ENCODED DATA/>'),
@@ -166,7 +166,7 @@ public function dataFormatsAndResultsProvider()
      *
      * @return array
      */
-    public function dataProvider()
+    public static function dataProvider()
     {
         return array(
             array(array('apple')),

tests/unit_tests/coders/datafile_coders/datafile_decoders/DatafileDecoderTest.php

@@ -229,7 +229,7 @@ public function testDecodeFileWhenDataFormatIsNotSet()
      *
      * @return array
      */
-    public function dataFormatsAndResultsProvider()
+    public static function dataFormatsAndResultsProvider()
     {
         return array(
             array('format1', array('<FORMAT 1 DECODED DATA/>')),

tests/unit_tests/coders/datafile_coders/datafile_encoders/DatafileEncoderTest.php

@@ -222,7 +222,7 @@ public function testEncodeFileWhenDataFormatIsNotSet()
      *
      * @return array
      */
-    public function dataFormatsAndResultsProvider()
+    public static function dataFormatsAndResultsProvider()
     {
         return array(
             array('format1', '<FORMAT 1 ENCODED DATA/>'),

tests/unit_tests/data_format/DataFormatTest.php

@@ -58,7 +58,7 @@ public function testDataFormatsItems($formatAbbreviation, $expectedFormatFullNam
      *
      * @return array
      */
-    public function formatAbbreviationAndFullNameProvider()
+    public static function formatAbbreviationAndFullNameProvider()
     {
         return array(
             array('JSON', 'JSON'),

tests/unit_tests/file/FileTest.php

@@ -303,7 +303,7 @@ public function testSetContent($filePath, $fileContent)
      *
      * @return array
      */
-    public function filePathExtensionProvider()
+    public static function filePathExtensionProvider()
     {
         return array(
             array('file', ''),
@@ -319,7 +319,7 @@ public function filePathExtensionProvider()
      *
      * @return array
      */
-    public function fileForReadPathAndContentProvider()
+    public static function fileForReadPathAndContentProvider()
     {
         return array(
             array(self::buildFileFixturePath('file-for-read'), 'File for read'),
@@ -335,7 +335,7 @@ public function fileForReadPathAndContentProvider()
      *
      * @return array
      */
-    public function fileForWritePathAndContentProvider()
+    public static function fileForWritePathAndContentProvider()
     {
         return array(
             array(self::buildFileFixturePath('file-for-write'), 'File for write'),
@@ -355,7 +355,7 @@ public function fileForWritePathAndContentProvider()
      *
      * @return array
      */
-    public function improperFileContentProvider()
+    public static function improperFileContentProvider()
     {
         return array(
             array(null),