Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates does not support Linux arm64 etc. #241

Open
eitsupi opened this issue Feb 21, 2023 · 9 comments
Open

Templates does not support Linux arm64 etc. #241

eitsupi opened this issue Feb 21, 2023 · 9 comments

Comments

@eitsupi
Copy link
Contributor

eitsupi commented Feb 21, 2023

Reported in PRQL/prqlc-r#88 by @andresrcs

It seems that packages based on rextendr templates such as extendr/helloextendr cannot be installed on Linux arm64 platform.
I wonder if rextendr need to generate Cargo.toml that would enable libR-sys's use-bindgen feature except on certain platforms?
https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#platform-specific-dependencies

@yutannihilation
Copy link
Contributor

Another option is to fix this on libR-sys's side. The CI should be able to generate the bindings for aarch64-unknown-linux-gnu by cross-compiling.

@eitsupi
Copy link
Contributor Author

eitsupi commented Feb 21, 2023

Another option is to fix this on libR-sys's side. The CI should be able to generate the bindings for aarch64-unknown-linux-gnu by cross-compiling.

Thanks for the reply. This is definitely an attractive option and I hope this will happen at least on linux/arm64.

However, I still think the template needs to be improved, since it will not be possible to install any packages generated from rextendr on other platforms.

@eitsupi
Copy link
Contributor Author

eitsupi commented Feb 22, 2023

I have tried working as advised by @yutannihilation, but it doesn't seem to work and it works.
It would be helpful if you could take a look at extendr/libR-sys#133 and try extendr/helloextendr#17.

@CGMossa
Copy link
Member

CGMossa commented Feb 24, 2023 via email

@eitsupi
Copy link
Contributor Author

eitsupi commented Feb 24, 2023

@CGMossa Thank you for looking at this.
I created extendr/helloextendr#17 simply to see if extendr/libR-sys#133 would work on a linux/arm64 machine (via remotes::install_github("extendr/helloextendr#17")), so CI does not need to be running.

@CGMossa
Copy link
Member

CGMossa commented Feb 24, 2023 via email

@JosiahParry
Copy link
Contributor

Is this fixed? I work exclusively on arm64 and have never ran into an issue.

@Ilia-Kosenkov
Copy link
Member

No, not yet. At least we made no attempts to fix that. I am unsure if there is an issue still.

@eitsupi
Copy link
Contributor Author

eitsupi commented Jun 23, 2023

Is this fixed? I work exclusively on arm64 and have never ran into an issue.

See extendr/libR-sys#133.
Linux arm64 is now supported since bindings were added to libR-sys, but continues to be not supported on all platforms except Windows x86, Windows amd64, macOS amd64, macOS arm64, Linux amd64, and Linux arm64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants