refactor(macro): use #[php] attribute for startup function

This unifies the behaviour of the `#[php_module]` macro and the other `#[php_*]` macros.

Refs: #423

Author: Xenira

crates/macros/src/lib.rs

@@ -499,10 +499,10 @@ pub fn php_const(_args: TokenStream, input: TokenStream) -> TokenStream {
 /// # fn main() {}
 /// ```
 #[proc_macro_attribute]
-pub fn php_module(args: TokenStream, input: TokenStream) -> TokenStream {
+pub fn php_module(_args: TokenStream, input: TokenStream) -> TokenStream {
     let input = parse_macro_input!(input as ItemFn);
 
-    module::parser(args.into(), input)
+    module::parser(input)
         .unwrap_or_else(|e| e.to_compile_error())
         .into()
 }

crates/macros/src/module.rs

@@ -1,27 +1,23 @@
-use darling::{ast::NestedMeta, FromMeta};
+use darling::FromAttributes;
 use proc_macro2::{Ident, TokenStream};
 use quote::quote;
 use syn::{ItemFn, Signature};
 
 use crate::prelude::*;
 
-#[derive(Debug, Default, FromMeta)]
-#[darling(default)]
-pub struct ModuleArgs {
-    /// Optional function that will be called when the module starts up.
+#[derive(FromAttributes, Default, Debug)]
+#[darling(default, attributes(php))]
+pub(crate) struct PhpModuleAttribute {
     startup: Option<Ident>,
 }
 
-pub fn parser(args: TokenStream, input: ItemFn) -> Result<TokenStream> {
-    let meta = NestedMeta::parse_meta_list(args)?;
-    let opts = match ModuleArgs::from_list(&meta) {
-        Ok(opts) => opts,
-        Err(e) => bail!(input => "Failed to parse attribute options: {:?}", e),
-    };
+pub fn parser(input: ItemFn) -> Result<TokenStream> {
     let ItemFn { sig, block, .. } = input;
     let Signature { output, inputs, .. } = sig;
     let stmts = &block.stmts;
-    let startup = if let Some(startup) = opts.startup {
+
+    let attr = PhpModuleAttribute::from_attributes(&input.attrs)?;
+    let startup = if let Some(startup) = attr.startup {
         quote! { #startup(ty, mod_num) }
     } else {
         quote! { 0i32 }

examples/hello_world.rs

@@ -76,7 +76,8 @@ fn startup(_ty: i32, mod_num: i32) -> i32 {
     0
 }
 
-#[php_module(startup = "startup")]
+#[php_module]
+#[php(startup = startup)]
 pub fn get_module(module: ModuleBuilder) -> ModuleBuilder {
     module
         .class::<TestClass>()

guide/src/ini-settings.md

@@ -27,7 +27,8 @@ pub fn startup(ty: i32, mod_num: i32) -> i32 {
     0
 }
 
-#[php_module(startup = "startup")]
+#[php_module]
+#[php(startup = "startup")]
 pub fn get_module(module: ModuleBuilder) -> ModuleBuilder {
     module
 }
@@ -54,7 +55,8 @@ pub fn startup(ty: i32, mod_num: i32) -> i32 {
     0
 }
 
-#[php_module(startup = "startup")]
+#[php_module]
+#[php(startup = "startup")]
 pub fn get_module(module: ModuleBuilder) -> ModuleBuilder {
     module
 }

guide/src/migration-guides/v0.14.md

@@ -15,7 +15,8 @@ register functions, classes, constants and startup function when declaring
 the module.
 
 ```rs
-#[php_module(startup = "startup_function")]
+#[php_module]
+#[php(startup = "startup_function")]
 pub fn get_module(module: ModuleBuilder) -> ModuleBuilder {
     module
         .class::<TestClass>()
@@ -174,7 +175,8 @@ fn startup_function(ty: i32, mod_num: i32) -> i32 {
     0
 }
 
-#[php_module(startup = "startup_function")]
+#[php_module]
+#[php(startup = "startup_function")]
 pub fn get_module(module: ModuleBuilder) -> ModuleBuilder {
     module
 }