Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File selector should jump back and highlight unstaged files #2476

Closed
castn opened this issue Jan 12, 2025 · 2 comments · Fixed by #2499
Closed

File selector should jump back and highlight unstaged files #2476

castn opened this issue Jan 12, 2025 · 2 comments · Fixed by #2499
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@castn
Copy link

castn commented Jan 12, 2025

Describe the bug
When you make a commit from staged changes and actually do the commit so that the commit message popup closes, the file highlighter does not jump back into the unstaged changes section. It only does this when you use the arrow up/down keys.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Status tab
  2. Select unstaged changes and stage them
  3. Create a commit and write a message and finish it. So the popup window with the commit message input closes
  4. Now there is no file selector in the unstaged changes section only after you use the arrow key up/down

Expected behavior
I would expect that after a commit, at least the first item in the unstaged changes list is highlighted. So that you get a visual feedback where you are when you move the arrow keys up and down.

@castn castn added the bug Something isn't working label Jan 12, 2025
@extrawurst extrawurst added enhancement New feature or request good first issue Good for newcomers labels Jan 12, 2025
@tommady
Copy link
Contributor

tommady commented Jan 24, 2025

Hi, may I give it a try?

@tommady
Copy link
Contributor

tommady commented Jan 28, 2025

hi @extrawurst could you help to review the PR?
thanks.

@extrawurst extrawurst added this to the v0.28 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants