Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variables and tables comparison broken for ApplicationService #248

Open
juliantaylor opened this issue Feb 13, 2020 · 1 comment
Open

variables and tables comparison broken for ApplicationService #248

juliantaylor opened this issue Feb 13, 2020 · 1 comment

Comments

@juliantaylor
Copy link

the comparison of the variables and tables in the ApplicationService in the equality operator is broken when the length of the lists change:
https://github.com/f5devcentral/f5-cccl/blob/master/f5_cccl/resource/ltm/app_service.py#L62

        if not all(v in self._data['variables']
                   for v in other.data['variables']):

This comparison will fail when the other list is shorter than the self list.
This breaks the for example update using the k8s-bigipcontroller see F5Networks/k8s-bigip-ctlr#1038

@juliantaylor
Copy link
Author

simple fix is to compare the length of the lists for equality first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant