chore(): update playwright #10780
chore(): update playwright #10780
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
Build Stats
|
| private async _executeInBrowserImpl( | ||
| runInBrowser: any, | ||
| context?: any, | ||
| ): Promise<any> { |
There was a problem hiding this comment.
yeah i see. This will be hard to remember in a month or two why is in this way. Let me think if some ts notation is a bit better for this.
There was a problem hiding this comment.
i wrote on the issue I opened in playwright that i dislike this approach they suggested
first I had it with just copying the type manually
but I am not sure which one approach is worse
lets see if they reexport the type again, if not then you will have to decide on how to proceed
but in any case, just slapping any type I think is the least optimal solution
|
@asturur the playwright issue I filed has been closed without interest to export the type again |
2 participants
I have opened an issue microsoft/playwright#37855
because I dislike the solution I came up with, and also I dislike the solution that playwright maintainer suggests.
Lets see if they export the type again, or we have to stick with this.
I would not merge this until the playwright issue is closed