Skip to content

Commit 14e9c75

Browse files
mdvaccafacebook-github-bot
authored andcommitted
Rename ReactNativeFeatureFlagsProviderHolder -> ReactNativeFeatureFlagsJavaProvider (#50080)
Summary: I'm renaming ReactNativeFeatureFlagsProviderHolder -> ReactNativeFeatureFlagsJavaProvider to make naming consistent with documentation and remove the concept of "Holder" which is not part of the original design changelog: [internal] internal Reviewed By: rubennorte Differential Revision: D71333170
1 parent e01ccee commit 14e9c75

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

packages/react-native/ReactAndroid/src/main/jni/react/featureflags/JReactNativeFeatureFlagsCxxInterop.cpp

+5-5
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<c866e69278d249dd79cb2fc193d1a7e2>>
7+
* @generated SignedSource<<9dedcd0160e4271cd3bf373a2c044cb4>>
88
*/
99

1010
/**
@@ -32,10 +32,10 @@ static jni::alias_ref<jni::JClass> getReactNativeFeatureFlagsProviderJavaClass()
3232
* Implementation of ReactNativeFeatureFlagsProvider that wraps a
3333
* ReactNativeFeatureFlagsProvider Java object.
3434
*/
35-
class ReactNativeFeatureFlagsProviderHolder
35+
class ReactNativeFeatureFlagsJavaProvider
3636
: public ReactNativeFeatureFlagsProvider {
3737
public:
38-
explicit ReactNativeFeatureFlagsProviderHolder(
38+
explicit ReactNativeFeatureFlagsJavaProvider(
3939
jni::alias_ref<jobject> javaProvider)
4040
: javaProvider_(make_global(javaProvider)){};
4141

@@ -509,7 +509,7 @@ void JReactNativeFeatureFlagsCxxInterop::override(
509509
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/,
510510
jni::alias_ref<jobject> provider) {
511511
ReactNativeFeatureFlags::override(
512-
std::make_unique<ReactNativeFeatureFlagsProviderHolder>(provider));
512+
std::make_unique<ReactNativeFeatureFlagsJavaProvider>(provider));
513513
}
514514

515515
void JReactNativeFeatureFlagsCxxInterop::dangerouslyReset(
@@ -521,7 +521,7 @@ jni::local_ref<jstring> JReactNativeFeatureFlagsCxxInterop::dangerouslyForceOver
521521
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/,
522522
jni::alias_ref<jobject> provider) {
523523
auto accessedFlags = ReactNativeFeatureFlags::dangerouslyForceOverride(
524-
std::make_unique<ReactNativeFeatureFlagsProviderHolder>(provider));
524+
std::make_unique<ReactNativeFeatureFlagsJavaProvider>(provider));
525525
if (accessedFlags.has_value()) {
526526
return jni::make_jstring(accessedFlags.value());
527527
}

packages/react-native/scripts/featureflags/templates/android/JReactNativeFeatureFlagsCxxInterop.cpp-template.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,10 @@ static jni::alias_ref<jni::JClass> getReactNativeFeatureFlagsProviderJavaClass()
4040
* Implementation of ReactNativeFeatureFlagsProvider that wraps a
4141
* ReactNativeFeatureFlagsProvider Java object.
4242
*/
43-
class ReactNativeFeatureFlagsProviderHolder
43+
class ReactNativeFeatureFlagsJavaProvider
4444
: public ReactNativeFeatureFlagsProvider {
4545
public:
46-
explicit ReactNativeFeatureFlagsProviderHolder(
46+
explicit ReactNativeFeatureFlagsJavaProvider(
4747
jni::alias_ref<jobject> javaProvider)
4848
: javaProvider_(make_global(javaProvider)){};
4949
@@ -80,7 +80,7 @@ void JReactNativeFeatureFlagsCxxInterop::override(
8080
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/,
8181
jni::alias_ref<jobject> provider) {
8282
ReactNativeFeatureFlags::override(
83-
std::make_unique<ReactNativeFeatureFlagsProviderHolder>(provider));
83+
std::make_unique<ReactNativeFeatureFlagsJavaProvider>(provider));
8484
}
8585
8686
void JReactNativeFeatureFlagsCxxInterop::dangerouslyReset(
@@ -92,7 +92,7 @@ jni::local_ref<jstring> JReactNativeFeatureFlagsCxxInterop::dangerouslyForceOver
9292
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/,
9393
jni::alias_ref<jobject> provider) {
9494
auto accessedFlags = ReactNativeFeatureFlags::dangerouslyForceOverride(
95-
std::make_unique<ReactNativeFeatureFlagsProviderHolder>(provider));
95+
std::make_unique<ReactNativeFeatureFlagsJavaProvider>(provider));
9696
if (accessedFlags.has_value()) {
9797
return jni::make_jstring(accessedFlags.value());
9898
}

0 commit comments

Comments
 (0)