Skip to content

Commit d08f9ac

Browse files
NickGerlemanfacebook-github-bot
authored andcommitted
Back out "Wire up native box shadow parsing" (#49345)
Summary: Pull Request resolved: #49345 This diff is causing an error to be logged for every user. Even if it's noise, its more trouble than its worth. Let's revert until feature flags check fixed. Changelog: [Internal] Reviewed By: makovkastar Differential Revision: D69504966 fbshipit-source-id: 13caf715cef9a4cc6c9b7c68d3003fbced870d34
1 parent 578e99a commit d08f9ac

File tree

5 files changed

+99
-319
lines changed

5 files changed

+99
-319
lines changed

packages/react-native/Libraries/NativeComponent/BaseViewConfig.android.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
import type {PartialViewConfigWithoutName} from './PlatformBaseViewConfig';
1212

13-
import * as ReactNativeFeatureFlags from '../../src/private/featureflags/ReactNativeFeatureFlags';
1413
import ReactNativeStyleAttributes from '../Components/View/ReactNativeStyleAttributes';
1514
import {DynamicallyInjectedByGestureHandler} from './ViewConfigIgnore';
1615

@@ -171,9 +170,7 @@ const validAttributesForNonEventProps = {
171170
process: require('../StyleSheet/processBackgroundImage').default,
172171
},
173172
boxShadow: {
174-
process: ReactNativeFeatureFlags.enableNativeCSSParsing()
175-
? undefined
176-
: require('../StyleSheet/processBoxShadow').default,
173+
process: require('../StyleSheet/processBoxShadow').default,
177174
},
178175
filter: {
179176
process: require('../StyleSheet/processFilter').default,

packages/react-native/Libraries/NativeComponent/BaseViewConfig.ios.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
import type {PartialViewConfigWithoutName} from './PlatformBaseViewConfig';
1212

13-
import * as ReactNativeFeatureFlags from '../../src/private/featureflags/ReactNativeFeatureFlags';
1413
import ReactNativeStyleAttributes from '../Components/View/ReactNativeStyleAttributes';
1514
import {
1615
ConditionallyIgnoredEventHandlers,
@@ -230,9 +229,7 @@ const validAttributesForNonEventProps = {
230229
process: require('../StyleSheet/processFilter').default,
231230
},
232231
boxShadow: {
233-
process: ReactNativeFeatureFlags.enableNativeCSSParsing()
234-
? undefined
235-
: require('../StyleSheet/processBoxShadow').default,
232+
process: require('../StyleSheet/processBoxShadow').default,
236233
},
237234
mixBlendMode: true,
238235
isolation: true,

packages/react-native/ReactCommon/react/renderer/components/view/BaseViewProps.cpp

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
#include <algorithm>
1111

1212
#include <react/featureflags/ReactNativeFeatureFlags.h>
13-
#include <react/renderer/components/view/BoxShadowPropsConversions.h>
1413
#include <react/renderer/components/view/conversions.h>
1514
#include <react/renderer/components/view/primitives.h>
1615
#include <react/renderer/components/view/propsConversions.h>

packages/react-native/ReactCommon/react/renderer/components/view/BoxShadowPropsConversions.h

-310
This file was deleted.

0 commit comments

Comments
 (0)