Correctly compare oldProps in RCTPullToRefreshViewComponentView (#50092)

javache · facebook-github-bot · commit fab7fa88e3bd · 2025-03-18T05:23:29.000-07:00
Summary: Pull Request resolved: #50092 `oldProps` can be null, so this is an unsafe dereference. We also typically compare with `_props`, which represents the previous state of the component. Changelog: [General][Fixed] Fixed crash in RCTPullToRefreshViewComponentView#updateProps Reviewed By: cipolleschi Differential Revision: D71388015 fbshipit-source-id: deff9c581ee207c4481056a720c10dfd661f088d
diff --git a/packages/react-native/React/Fabric/Mounting/ComponentViews/ScrollView/RCTPullToRefreshViewComponentView.mm b/packages/react-native/React/Fabric/Mounting/ComponentViews/ScrollView/RCTPullToRefreshViewComponentView.mm
@@ -76,7 +76,7 @@ - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &
     return;
   }
 
-  const auto &oldConcreteProps = static_cast<const PullToRefreshViewProps &>(*oldProps);
+  const auto &oldConcreteProps = static_cast<const PullToRefreshViewProps &>(*_props);
   const auto &newConcreteProps = static_cast<const PullToRefreshViewProps &>(*props);
 
   if (newConcreteProps.tintColor != oldConcreteProps.tintColor) {

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &`
`76`	`76`	`return;`
`77`	`77`	`}`
`78`	`78`
`79`		`- const auto &oldConcreteProps = static_cast<const PullToRefreshViewProps &>(*oldProps);`
	`79`	`+ const auto &oldConcreteProps = static_cast<const PullToRefreshViewProps &>(*_props);`
`80`	`80`	`const auto &newConcreteProps = static_cast<const PullToRefreshViewProps &>(*props);`
`81`	`81`
`82`	`82`	`if (newConcreteProps.tintColor != oldConcreteProps.tintColor) {`