Skip to content

Commit fedb9de

Browse files
GijsWeteringsfacebook-github-bot
authored andcommitted
Apply Nullsafe FIXMEs for xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/StackTraceHelper.java (#50053)
Summary: Note this diff is only adding FIXMEs that will be removed in the next diff. This diff exists to make the next diff easily reviewable Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D71126384
1 parent 77cdaa8 commit fedb9de

File tree

1 file changed

+16
-0
lines changed

1 file changed

+16
-0
lines changed

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/StackTraceHelper.java

+16
Original file line numberDiff line numberDiff line change
@@ -137,23 +137,34 @@ public static StackFrame[] convertJsStackTrace(@Nullable ReadableArray stack) {
137137
int size = stack != null ? stack.size() : 0;
138138
StackFrame[] result = new StackFrame[size];
139139
for (int i = 0; i < size; i++) {
140+
// NULLSAFE_FIXME[Nullable Dereference]
140141
ReadableType type = stack.getType(i);
141142
if (type == ReadableType.Map) {
143+
// NULLSAFE_FIXME[Nullable Dereference]
142144
ReadableMap frame = stack.getMap(i);
145+
// NULLSAFE_FIXME[Nullable Dereference]
143146
String methodName = frame.getString("methodName");
147+
// NULLSAFE_FIXME[Nullable Dereference]
144148
String fileName = frame.getString("file");
145149
boolean collapse =
150+
// NULLSAFE_FIXME[Nullable Dereference]
146151
frame.hasKey("collapse") && !frame.isNull("collapse") && frame.getBoolean("collapse");
147152
int lineNumber = -1;
153+
// NULLSAFE_FIXME[Nullable Dereference]
148154
if (frame.hasKey(LINE_NUMBER_KEY) && !frame.isNull(LINE_NUMBER_KEY)) {
155+
// NULLSAFE_FIXME[Nullable Dereference]
149156
lineNumber = frame.getInt(LINE_NUMBER_KEY);
150157
}
151158
int columnNumber = -1;
159+
// NULLSAFE_FIXME[Nullable Dereference]
152160
if (frame.hasKey(COLUMN_KEY) && !frame.isNull(COLUMN_KEY)) {
161+
// NULLSAFE_FIXME[Nullable Dereference]
153162
columnNumber = frame.getInt(COLUMN_KEY);
154163
}
164+
// NULLSAFE_FIXME[Parameter Not Nullable]
155165
result[i] = new StackFrameImpl(fileName, methodName, lineNumber, columnNumber, collapse);
156166
} else if (type == ReadableType.String) {
167+
// NULLSAFE_FIXME[Parameter Not Nullable, Nullable Dereference]
157168
result[i] = new StackFrameImpl(null, stack.getString(i), -1, -1);
158169
}
159170
}
@@ -203,14 +214,18 @@ public static StackFrame[] convertJsStackTrace(String stack) {
203214
} else if (matcher1.find()) {
204215
matcher = matcher1;
205216
} else {
217+
// NULLSAFE_FIXME[Parameter Not Nullable]
206218
result[i] = new StackFrameImpl(null, stackTrace[i], -1, -1);
207219
continue;
208220
}
209221
result[i] =
210222
new StackFrameImpl(
223+
// NULLSAFE_FIXME[Parameter Not Nullable]
211224
matcher.group(2),
212225
matcher.group(1) == null ? "(unknown)" : matcher.group(1),
226+
// NULLSAFE_FIXME[Parameter Not Nullable]
213227
Integer.parseInt(matcher.group(3)),
228+
// NULLSAFE_FIXME[Parameter Not Nullable]
214229
Integer.parseInt(matcher.group(4)));
215230
}
216231
return result;
@@ -224,6 +239,7 @@ public static StackFrame[] convertJavaStackTrace(Throwable exception) {
224239
result[i] =
225240
new StackFrameImpl(
226241
stackTrace[i].getClassName(),
242+
// NULLSAFE_FIXME[Parameter Not Nullable]
227243
stackTrace[i].getFileName(),
228244
stackTrace[i].getMethodName(),
229245
stackTrace[i].getLineNumber(),

0 commit comments

Comments
 (0)