Make many relay object types readonly or annotate objects to prevent future flow errors after object literal soundness fix: 2/n

Reviewed By: marcoww6

Differential Revision: D76989506

fbshipit-source-id: 3742260c46bd24b2176d9794493f619e26562ae0

Author: SamChou19815

packages/react-relay/__tests__/ReactRelayTestMocker-test.js

@@ -12,6 +12,7 @@
 'use strict';
 import type {RelayMockEnvironment} from '../../relay-test-utils/RelayModernMockEnvironment';
 import type {NetworkWriteConfig} from '../ReactRelayTestMocker';
+import type {GeneratedNodeMap} from '../ReactRelayTypes';
 
 const RelayTestRenderer = require('../__mocks__/RelayTestRenderer');
 const {
@@ -47,7 +48,7 @@ const ReactRelayTestMockerTestNestedQuery = graphql`
     }
   }
 `;
-const ReactRelayTestMockerTest_meFragmentDefinition = {
+const ReactRelayTestMockerTest_meFragmentDefinition: GeneratedNodeMap = {
   me: graphql`
     fragment ReactRelayTestMockerTest_me on User {
       name

packages/react-relay/relay-hooks/EntryPointTypes.flow.js

@@ -293,6 +293,6 @@ export type EntryPoint<TEntryPointParams, +TEntryPointComponent> =
 
 export type PreloadParamsOf<T> = Parameters<T['getPreloadProps']>[0];
 
-export type IEnvironmentProvider<TOptions> = {
+export type IEnvironmentProvider<TOptions> = $ReadOnly<{
   getEnvironment: (options: ?TOptions) => IEnvironment,
-};
+}>;

packages/react-relay/relay-hooks/__tests__/useSubscribeToInvalidationState-test.js

@@ -10,7 +10,9 @@
  */
 
 'use strict';
+
 import type {RelayMockEnvironment} from '../../../relay-test-utils/RelayModernMockEnvironment';
+import type {RecordSourceJSON} from 'relay-runtime/store/RelayStoreTypes';
 
 const RelayEnvironmentProvider = require('../RelayEnvironmentProvider');
 const useSubscribeToInvalidationState = require('../useSubscribeToInvalidationState');
@@ -27,7 +29,7 @@ let setDataIDs;
 let setCallback;
 let disposable;
 let renderedInstance;
-let data;
+let data: RecordSourceJSON;
 let callback;
 
 beforeEach(() => {

packages/relay-runtime/mutations/commitMutation.js

@@ -37,7 +37,7 @@ const validateMutation = require('./validateMutation');
 const invariant = require('invariant');
 const warning = require('warning');
 
-export type MutationConfig<TMutation: MutationParameters> = {
+export type MutationConfig<TMutation: MutationParameters> = $ReadOnly<{
   cacheConfig?: CacheConfig,
   configs?: Array<DeclarativeMutationConfig>,
   mutation: GraphQLTaggedNode,
@@ -57,9 +57,9 @@ export type MutationConfig<TMutation: MutationParameters> = {
   updater?: ?SelectorStoreUpdater<TMutation['response']>,
   uploadables?: UploadableMap,
   variables: TMutation['variables'],
-};
+}>;
 
-export type CommitMutationConfig<TVariables, TData, TRawResponse> = {
+export type CommitMutationConfig<TVariables, TData, TRawResponse> = $ReadOnly<{
   cacheConfig?: CacheConfig,
   configs?: Array<DeclarativeMutationConfig>,
   mutation: Mutation<TVariables, TData, TRawResponse>,
@@ -72,7 +72,7 @@ export type CommitMutationConfig<TVariables, TData, TRawResponse> = {
   updater?: ?SelectorStoreUpdater<TData>,
   uploadables?: UploadableMap,
   variables: TVariables,
-};
+}>;
 
 /**
  * Higher-level helper function to execute a mutation against a specific

packages/relay-runtime/query/__tests__/fetchQueryInternal-test.js

@@ -10,7 +10,10 @@
  */
 
 'use strict';
-import type {GraphQLResponse} from '../../network/RelayNetworkTypes';
+import type {
+  GraphQLResponse,
+  GraphQLSingularResponse,
+} from '../../network/RelayNetworkTypes';
 import type {Subscription} from '../../network/RelayObservable';
 import type {Observer} from '../../network/RelayObservable';
 import type {NormalizationSplitOperation} from '../../util/NormalizationNode';
@@ -41,7 +44,7 @@ const {
 
 injectPromisePolyfill__DEPRECATED();
 
-let response;
+let response: GraphQLSingularResponse;
 let gqlQuery:
   | Query<
       fetchQueryInternalTest1Query$variables,

packages/relay-runtime/store/__tests__/DataChecker-test.js

@@ -176,7 +176,7 @@ describe('check()', () => {
   });
 
   it('reads fragment data', () => {
-    const data = {
+    const data: RecordSourceJSON = {
       '1': {
         __id: '1',
         id: '1',

packages/relay-runtime/store/__tests__/RelayResponseNormalizer-test.js

@@ -11,6 +11,7 @@
 
 'use strict';
 
+import type {PayloadData, PayloadError} from '../../network/RelayNetworkTypes';
 import type {RecordSourceJSON} from '../RelayStoreTypes';
 
 const {
@@ -4136,7 +4137,7 @@ describe('RelayResponseNormalizer', () => {
         }
       `;
 
-      const payload = {};
+      const payload: PayloadData = {};
       const recordSource = new RelayRecordSource();
       recordSource.set(ROOT_ID, RelayModernRecord.create(ROOT_ID, ROOT_TYPE));
 
@@ -4199,7 +4200,7 @@ describe('RelayResponseNormalizer', () => {
           }
         }
       `;
-      const payload = {
+      const payload: PayloadData = {
         node: {
           id: '1',
           __typename: 'User',
@@ -4235,7 +4236,7 @@ describe('RelayResponseNormalizer', () => {
           },
         },
       };
-      const errors = [
+      const errors: Array<PayloadError> = [
         {
           message: "No one knows Kramer's first name until season six!",
           path: ['node', 'friends', 'edges', 1, 'node', 'firstName'],

packages/relay-runtime/subscription/requestSubscription.js

@@ -41,16 +41,17 @@ export type SubscriptionParameters = {
  * Updated Flow type that makes use of typed graphql tagged literals with
  * type information.
  */
-export type GraphQLSubscriptionConfig<TVariables, TData, TRawResponse> = {
-  configs?: Array<DeclarativeMutationConfig>,
-  cacheConfig?: CacheConfig,
-  subscription: GraphQLSubscription<TVariables, TData, TRawResponse>,
-  variables: TVariables,
-  onCompleted?: ?() => void,
-  onError?: ?(error: Error) => void,
-  onNext?: ?(response: ?TData) => void,
-  updater?: ?SelectorStoreUpdater<TData>,
-};
+export type GraphQLSubscriptionConfig<TVariables, TData, TRawResponse> =
+  $ReadOnly<{
+    configs?: Array<DeclarativeMutationConfig>,
+    cacheConfig?: CacheConfig,
+    subscription: GraphQLSubscription<TVariables, TData, TRawResponse>,
+    variables: TVariables,
+    onCompleted?: ?() => void,
+    onError?: ?(error: Error) => void,
+    onNext?: ?(response: ?TData) => void,
+    updater?: ?SelectorStoreUpdater<TData>,
+  }>;
 
 function requestSubscription<TVariables: Variables, TData, TRawResponse>(
   environment: IEnvironment,