-
Notifications
You must be signed in to change notification settings - Fork 350
Open
Description
Add a config to the try/catch to flag hard errors in enableMediaQueryOrder and fallback to pre-existing behaviour. Find a way to log or capture errors, possibly in new lint rule for the parser
See: #1147 where config was added
- Add new config to NOT throw when
lastMediaQueryWinsTransformfails in this try catch. Have it just "log" a warning - either through a linter or through other means. Investigate this: https://github.com/facebook/stylex/blob/main/packages/%40stylexjs/babel-plugin/src/shared/preprocess-rules/flatten-raw-style-obj.js#L29-L36 - If needed, add a lint rule that checks for
lastMediaQueryWinsTransformon media queries. You will need to addstyle-value-parseras a build step in npm ineslint-plugin. Lint rule should warn that media query order will NOT be respected iflastMediaQueryWinsTransformfails. This could be due to invalid media query OR edge cases missed instyle-value-parser - Sync to WWW. See error volume. Turn the
enforceMediaQueryOrderconfig ON internally.
Metadata
Metadata
Assignees
Labels
No labels