Fix CQS signal performance-faster-string-find in fbcode/glean/client

generatedunixname89002005287564 · meta-codesync[bot] · commit cb859cf7c88d · 2025-10-03T04:57:12.000-07:00
Reviewed By: Wilfred

Differential Revision: D83817667

fbshipit-source-id: 7b5db8d3f24225d10921715fe63125592335393a
diff --git a/glean/client/swift/JsonServer.cpp b/glean/client/swift/JsonServer.cpp
@@ -134,7 +134,7 @@ folly::coro::Task<void> JsonServer::processRequest(
 
     // Replace single quotes with escaped version to prevent quote injection
     size_t pos = 0;
-    while ((pos = safeInput.find("'", pos)) != std::string::npos) {
+    while ((pos = safeInput.find('\'', pos)) != std::string::npos) {
       safeInput.replace(pos, 1, "\\'");
       pos += 2; // Move past the escaped quote
     }

Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,7 @@ folly::coro::Task<void> JsonServer::processRequest(`
`134`	`134`
`135`	`135`	`// Replace single quotes with escaped version to prevent quote injection`
`136`	`136`	`size_t pos = 0;`
`137`		`- while ((pos = safeInput.find("'", pos)) != std::string::npos) {`
	`137`	`+ while ((pos = safeInput.find('\'', pos)) != std::string::npos) {`
`138`	`138`	`safeInput.replace(pos, 1, "\\'");`
`139`	`139`	`pos += 2; // Move past the escaped quote`
`140`	`140`	`}`