Skip to content

Commit edf92cf

Browse files
ericweb2meta-codesync[bot]
authored andcommitted
Stop building Intel binaries for swift_glass_client.dotslash.py
Summary: **tl;dr: Accept this diff to stop shipping Intel Mac Binaries since:** - **Nearly much everyone is on Apple Silicon Macs** - **We'll stop supporting Intel Macs soon: https://fb.workplace.com/groups/iosfuture/posts/31401944746094074** - **You'll get faster deploys (since you don't have to build Intel binaries)** Do _not_ accept this diff if your customers are still using Intel Mac binaries. However, you'll need to address this manually before June 2026: https://fb.workplace.com/groups/iosfuture/posts/31401944746094074. # What is this diff? Currently, this config builds binaries for both Intel and Apple Silicon Macs. However, across all DotSlash + MSDK + SRConveyor configs, 99.8% of actual usages have been on Apple Silicon Macs. We should stops building Intel Mac Binaries since DevInfra + FOA will no longer support Intel Macs soon: https://fb.workplace.com/groups/iosfuture/posts/30705795575708998. This diff stops building Intel Mac binaries for this config. # Is this diff safe? The vast majority of developers and users are on Apple Silicon Macs. This should be a no-op, except you'll get the time and CIDU savings of no longer having to build Intel Mac binaries. # What if this breaks? In this highly-unlikely case, simply revert this diff. Then trigger another DotSlash, MSDK, or SRConveyor build. # Questions? - Put your question in the comments - Send this diff Back to Author. Reviewed By: Wilfred Differential Revision: D101079354 fbshipit-source-id: cf3fceb523f4d8072f0969e3e9071aadde4870b9
1 parent 3b1ad06 commit edf92cf

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

glean/client/swift/msdk/swift_glass_client.dotslash.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
install_platforms={
1515
dotslash.InstallPlatform.LINUX_X86_64,
1616
dotslash.InstallPlatform.LINUX_AARCH64,
17-
dotslash.InstallPlatform.MAC,
1817
dotslash.InstallPlatform.MAC_AARCH64,
1918
},
2019
oncall="swift_lsp",

0 commit comments

Comments
 (0)