Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator isBlockedTiming updating is wrong #12173

Open
lingbin opened this issue Jan 26, 2025 · 1 comment · May be fixed by #12174
Open

Operator isBlockedTiming updating is wrong #12173

lingbin opened this issue Jan 26, 2025 · 1 comment · May be fixed by #12174
Labels
bug Something isn't working triage Newly created issue that needs attention.

Comments

@lingbin
Copy link
Contributor

lingbin commented Jan 26, 2025

Bug description

velox/velox/exec/Driver.cpp

Lines 577 to 583 in 6010f95

withDeltaCpuWallTimer(op, &OperatorStats::isBlockedTiming, [&]() {
CALL_OPERATOR(
blockingReason_ = nextOp->isBlocked(&future),
nextOp,
curOperatorId_ + 1,
kOpMethodIsBlocked);
});

The time consumed by nextOp->isBlocked() counted here should be accumulated to nextOp, not op.

This bug was introduced in #10906.

System information

N/A

Relevant logs

@lingbin lingbin added bug Something isn't working triage Newly created issue that needs attention. labels Jan 26, 2025
@lingbin
Copy link
Contributor Author

lingbin commented Jan 26, 2025

Created PR #12174 to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Newly created issue that needs attention.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant