diff --git a/torchbiggraph/converters/utils.py b/torchbiggraph/converters/utils.py index 670e02f..0a89a4a 100644 --- a/torchbiggraph/converters/utils.py +++ b/torchbiggraph/converters/utils.py @@ -42,7 +42,29 @@ def extract_gzip(gzip_path: Path, remove_finished: bool = False) -> Path: def extract_tar(fpath: Path) -> None: # extract file with tarfile.open(fpath, "r:gz") as tar: - tar.extractall(path=fpath.parent) + + import os + + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=fpath.parent) def gen_bar_updater(pbar: tqdm) -> Callable[[int, int, int], None]: