Add ci_skycastle RPM build CI signal for diff-time validation - #48
Merged
Conversation
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 13, 2026
Summary: Add diff-time Skycastle CI signals that run the full GCM and healthchecks packman RPM builds with `--build-local` so build-breaking changes are caught before landing instead of only by contbuild post-land. This would have caught the recent isort==7.0.0 breakage where a Python 3.10+ dependency was pinned but the build container used Python 3.9. Two `ci_skycastle` targets are added: one for `fb-gcm` and one for `fb-healthchecks`. Each runs `packman build` directly with `--build-local --only <pkg> --run-as-root` to execute the full RPM build pipeline (container setup via systemd-nspawn, pip install, pyoxidizer build) without publishing. Both are land-blocking, diff-only, with a 90-minute timeout on I3_SMALL|I4_SMALL instances. After a successful build, each workflow smoke-tests the resulting binary with `--help` and `--version`. The `ci_srcs` lists track all files that feed into the RPM builds: container and build shell scripts, Python sources, requirements files, pyoxidizer config, Makefile, and packman YAML. Differential Revision: D93157502
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 13, 2026
Summary: Add diff-time Skycastle CI signals that run the full GCM and healthchecks packman RPM builds with `--build-local` so build-breaking changes are caught before landing instead of only by contbuild post-land. This would have caught the recent isort==7.0.0 breakage where a Python 3.10+ dependency was pinned but the build container used Python 3.9. Two `ci_skycastle` targets are added: one for `fb-gcm` and one for `fb-healthchecks`. Each runs `packman build` directly with `--build-local --only <pkg> --run-as-root` to execute the full RPM build pipeline (container setup via systemd-nspawn, pip install, pyoxidizer build) without publishing. Both are land-blocking, diff-only, with a 90-minute timeout on I3_SMALL|I4_SMALL instances. After a successful build, each workflow smoke-tests the resulting binary with `--help` and `--version`. The `ci_srcs` lists track all files that feed into the RPM builds: container and build shell scripts, Python sources, requirements files, pyoxidizer config, Makefile, and packman YAML. Reviewed By: xman1979, gunchu Differential Revision: D93157502
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 14, 2026
Summary: Add diff-time Skycastle CI signals that run the full GCM and healthchecks packman RPM builds with `--build-local` so build-breaking changes are caught before landing instead of only by contbuild post-land. This would have caught the recent isort==7.0.0 breakage where a Python 3.10+ dependency was pinned but the build container used Python 3.9. Two `ci_skycastle` targets are added: one for `fb-gcm` and one for `fb-healthchecks`. Each runs `packman build` directly with `--build-local --only <pkg> --run-as-root` to execute the full RPM build pipeline (container setup via systemd-nspawn, pip install, pyoxidizer build) without publishing. Both are land-blocking, diff-only, with a 90-minute timeout on I3_SMALL|I4_SMALL instances. After a successful build, each workflow smoke-tests the resulting binary with `--help` and `--version`. The `ci_srcs` lists track all files that feed into the RPM builds: container and build shell scripts, Python sources, requirements files, pyoxidizer config, Makefile, and packman YAML. Reviewed By: xman1979, gunchu Differential Revision: D93157502
facebook-github-bot
force-pushed
the
export-D93157502
branch
from
February 14, 2026 00:23
df1f73c to
9cabd27
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 17, 2026
Summary: Add diff-time Skycastle CI signals that run the full GCM and healthchecks packman RPM builds with `--build-local` so build-breaking changes are caught before landing instead of only by contbuild post-land. This would have caught the recent isort==7.0.0 breakage where a Python 3.10+ dependency was pinned but the build container used Python 3.9. Two `ci_skycastle` targets are added: one for `fb-gcm` and one for `fb-healthchecks`. Each runs `packman build` directly with `--build-local --only <pkg> --run-as-root` to execute the full RPM build pipeline (container setup via systemd-nspawn, pip install, pyoxidizer build) without publishing. Both are land-blocking, diff-only, with a 90-minute timeout on I3_SMALL|I4_SMALL instances. After a successful build, each workflow smoke-tests the resulting binary with `--help` and `--version`. The `ci_srcs` lists track all files that feed into the RPM builds: container and build shell scripts, Python sources, requirements files, pyoxidizer config, Makefile, and packman YAML. Reviewed By: xman1979, gunchu Differential Revision: D93157502
facebook-github-bot
force-pushed
the
export-D93157502
branch
from
February 17, 2026 23:07
9cabd27 to
d86785d
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 17, 2026
Summary: Add diff-time Skycastle CI signals that run the full GCM and healthchecks packman RPM builds with `--build-local` so build-breaking changes are caught before landing instead of only by contbuild post-land. This would have caught the recent isort==7.0.0 breakage where a Python 3.10+ dependency was pinned but the build container used Python 3.9. Two `ci_skycastle` targets are added: one for `fb-gcm` and one for `fb-healthchecks`. Each runs `packman build` directly with `--build-local --only <pkg> --run-as-root` to execute the full RPM build pipeline (container setup via systemd-nspawn, pip install, pyoxidizer build) without publishing. Both are land-blocking, diff-only, with a 90-minute timeout on I3_SMALL|I4_SMALL instances. After a successful build, each workflow smoke-tests the resulting binary with `--help` and `--version`. The `ci_srcs` lists track all files that feed into the RPM builds: container and build shell scripts, Python sources, requirements files, pyoxidizer config, Makefile, and packman YAML. Reviewed By: xman1979, gunchu Differential Revision: D93157502
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 18, 2026
Summary: Add diff-time Skycastle CI signals that run the full GCM and healthchecks packman RPM builds with `--build-local` so build-breaking changes are caught before landing instead of only by contbuild post-land. This would have caught the recent isort==7.0.0 breakage where a Python 3.10+ dependency was pinned but the build container used Python 3.9. Two `ci_skycastle` targets are added: one for `fb-gcm` and one for `fb-healthchecks`. Each runs `packman build` directly with `--build-local --only <pkg> --run-as-root` to execute the full RPM build pipeline (container setup via systemd-nspawn, pip install, pyoxidizer build) without publishing. Both are land-blocking, diff-only, with a 90-minute timeout on I3_SMALL|I4_SMALL instances. After a successful build, each workflow smoke-tests the resulting binary with `--help` and `--version`. The `ci_srcs` lists track all files that feed into the RPM builds: container and build shell scripts, Python sources, requirements files, pyoxidizer config, Makefile, and packman YAML. Reviewed By: xman1979, gunchu Differential Revision: D93157502
facebook-github-bot
force-pushed
the
export-D93157502
branch
from
February 18, 2026 01:55
d86785d to
761a10a
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 18, 2026
Summary: Add diff-time Skycastle CI signals that run the full GCM and healthchecks packman RPM builds with `--build-local` so build-breaking changes are caught before landing instead of only by contbuild post-land. This would have caught the recent isort==7.0.0 breakage where a Python 3.10+ dependency was pinned but the build container used Python 3.9. Two `ci_skycastle` targets are added: one for `fb-gcm` and one for `fb-healthchecks`. Each runs `packman build` directly with `--build-local --only <pkg> --run-as-root` to execute the full RPM build pipeline (container setup via systemd-nspawn, pip install, pyoxidizer build) without publishing. Both are land-blocking, diff-only, with a 90-minute timeout on I3_SMALL|I4_SMALL instances. After a successful build, each workflow smoke-tests the resulting binary with `--help` and `--version`. The `ci_srcs` lists track all files that feed into the RPM builds: container and build shell scripts, Python sources, requirements files, pyoxidizer config, Makefile, and packman YAML. Reviewed By: xman1979, gunchu Differential Revision: D93157502
Summary: Add diff-time Skycastle CI signals that run the full GCM and healthchecks packman RPM builds with `--build-local` so build-breaking changes are caught before landing instead of only by contbuild post-land. This would have caught the recent isort==7.0.0 breakage where a Python 3.10+ dependency was pinned but the build container used Python 3.9. Two `ci_skycastle` targets are added: one for `fb-gcm` and one for `fb-healthchecks`. Each runs `packman build` directly with `--build-local --only <pkg> --run-as-root` to execute the full RPM build pipeline (container setup via systemd-nspawn, pip install, pyoxidizer build) without publishing. Both are land-blocking, diff-only, with a 90-minute timeout on I3_SMALL|I4_SMALL instances. After a successful build, each workflow smoke-tests the resulting binary with `--help` and `--version`. The `ci_srcs` lists track all files that feed into the RPM builds: container and build shell scripts, Python sources, requirements files, pyoxidizer config, Makefile, and packman YAML. Reviewed By: xman1979, gunchu Differential Revision: D93157502
facebook-github-bot
force-pushed
the
export-D93157502
branch
from
February 18, 2026 02:40
761a10a to
571fb73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add diff-time Skycastle CI signals that run the full GCM and healthchecks packman RPM builds with
--build-localso build-breaking changes are caught before landing instead of only by contbuild post-land. This would have caught the recent isort==7.0.0 breakage where a Python 3.10+ dependency was pinned but the build container used Python 3.9.Two
ci_skycastletargets are added: one forfb-gcmand one forfb-healthchecks. Each runspackman builddirectly with--build-local --only <pkg> --run-as-rootto execute the full RPM build pipeline (container setup via systemd-nspawn, pip install, pyoxidizer build) without publishing. Both are land-blocking, diff-only, with a 90-minute timeout on I3_SMALL|I4_SMALL instances. After a successful build, each workflow smoke-tests the resulting binary with--helpand--version. Theci_srcslists track all files that feed into the RPM builds: container and build shell scripts, Python sources, requirements files, pyoxidizer config, Makefile, and packman YAML.Differential Revision: D93157502