Skip to content

Commit 00816ff

Browse files
committed
fix: audit cleanup
1 parent 9b21c1f commit 00816ff

File tree

9 files changed

+506
-511
lines changed

9 files changed

+506
-511
lines changed

.gas-snapshot

Lines changed: 495 additions & 495 deletions
Large diffs are not rendered by default.

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ jobs:
5555
- name: Wait for contract to be deployed
5656
uses: nick-fields/retry@v2
5757
with:
58-
timeout_seconds: 5
59-
retry_wait_seconds: 5
58+
timeout_seconds: 30
59+
retry_wait_seconds: 10
6060
max_attempts: 10
6161
shell: bash
6262
command: |

src/Bundler.sol

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ contract Bundler is IBundler {
2323
/**
2424
* @inheritdoc IBundler
2525
*/
26-
string public constant VERSION = "2025.06.13";
26+
string public constant VERSION = "2025.06.16";
2727

2828
/*//////////////////////////////////////////////////////////////
2929
IMMUTABLES
@@ -88,16 +88,11 @@ contract Bundler is IBundler {
8888

8989
function _addKeys(address fidOwner, SignerParams[] calldata signerParams) internal {
9090
uint256 signersLen = signerParams.length;
91-
for (uint256 i; i < signersLen;) {
91+
for (uint256 i; i < signersLen; ++i) {
9292
SignerParams calldata signer = signerParams[i];
9393
keyGateway.addFor(
9494
fidOwner, signer.keyType, signer.key, signer.metadataType, signer.metadata, signer.deadline, signer.sig
9595
);
96-
97-
// Safety: i can be incremented unchecked since it is bound by signerParams.length.
98-
unchecked {
99-
++i;
100-
}
10196
}
10297
}
10398

src/TierRegistry.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ contract TierRegistry is ITierRegistry, Migration {
2323
/**
2424
* @inheritdoc ITierRegistry
2525
*/
26-
string public constant VERSION = "2025.06.01";
26+
string public constant VERSION = "2025.06.16";
2727

2828
/*//////////////////////////////////////////////////////////////
2929
STORAGE

src/interfaces/ITierRegistry.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ interface ITierRegistry is IMigration {
6060
* @param forDays The number of days of subscription purchased
6161
* @param payer The address that paid
6262
*/
63-
event PurchasedTier(uint256 indexed fid, uint256 indexed tier, uint256 forDays, address payer);
63+
event PurchasedTier(uint256 indexed fid, uint256 indexed tier, uint256 forDays, address indexed payer);
6464

6565
/**
6666
* @notice Emitted when a tier is deactivated

test/Bundler/Bundler.t.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ contract BundlerTest is BundlerTestSuite {
2929
}
3030

3131
function testVersion() public {
32-
assertEq(bundler.VERSION(), "2025.06.13");
32+
assertEq(bundler.VERSION(), "2025.06.16");
3333
}
3434

3535
/*//////////////////////////////////////////////////////////////

test/TestSuiteSetup.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ abstract contract TestSuiteSetup is Test {
5959
function _assumeClean(
6060
address a
6161
) internal {
62-
assumeNoPrecompiles(a);
62+
assumeNotPrecompile(a);
6363
vm.assume(!isKnownContract[a]);
6464
vm.assume(a != ADMIN);
6565
vm.assume(a != address(0));

test/TierRegistry/TierRegistry.t.sol

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ contract TierRegistryTest is TierRegistryTestSuite {
1616
EVENTS
1717
//////////////////////////////////////////////////////////////*/
1818

19-
event PurchasedTier(uint256 indexed fid, uint256 indexed tier, uint256 forDays, address payer);
19+
event PurchasedTier(uint256 indexed fid, uint256 indexed tier, uint256 forDays, address indexed payer);
2020
event DeactivateTier(uint256 indexed tier);
2121
event SetTier(
2222
uint256 indexed tier,
@@ -35,7 +35,7 @@ contract TierRegistryTest is TierRegistryTestSuite {
3535
//////////////////////////////////////////////////////////////*/
3636

3737
function testVersion() public {
38-
assertEq(tierRegistry.VERSION(), "2025.06.01");
38+
assertEq(tierRegistry.VERSION(), "2025.06.16");
3939
}
4040

4141
function testOwner() public {

0 commit comments

Comments
 (0)