Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for new App Store Connect TestFlight API #246

Merged
merged 1 commit into from
Apr 24, 2019

Conversation

joshdholtz
Copy link
Member

Fixes #244
Fixes #245
Fixes fastlane/fastlane#14635

@clippka
Copy link

clippka commented Apr 23, 2019

IMHO app/services/.boarding_service.rb.swp was wrongly added?

@joshdholtz
Copy link
Member Author

@clippka lol, you are 100% correct 😱 Will fix

@joshdholtz joshdholtz force-pushed the joshdholtz-fix-removed-apis branch from 2b6f70d to 72ad119 Compare April 23, 2019 10:25
@joshdholtz joshdholtz changed the title Fixes issues with removed APIs by using new App Store Connect API Added support for new App Store Connect TestFlight API Apr 23, 2019
@jabeler
Copy link

jabeler commented Apr 23, 2019

Working here for me. Thanks! 👍

@joshdholtz joshdholtz merged commit 8a3619e into master Apr 24, 2019
@joshdholtz joshdholtz deleted the joshdholtz-fix-removed-apis branch April 24, 2019 17:47
@AlexeyLi
Copy link

AlexeyLi commented May 2, 2019

I just tried to deploy the latest version of the boarding app and it shows that I was successfully added as a new tester, but I didn't get an invite email and I'm not able to find myself when I check on TestFlight. I think this block of code doesn't get executed
client = Spaceship::ConnectAPI::Base.client response = client.request(:post) do |req| req.url("bulkBetaTesterAssignments") req.body = body.to_json req.headers['Content-Type'] = 'application/json', I tried adding logs with response.status and response.body to verify and I don't see them in the console either.

@janpio
Copy link
Member

janpio commented May 2, 2019

(Best create a new issue and link to this PR, otherwise this might get lost @AlexeyLi)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
7 participants