Skip to content

Commit e7ad78e

Browse files
authored
Merge pull request #185 from fastly/joeshaw/http-body-no-stream
don't fire off goroutine if underlying body is *fastly.HTTPBody
2 parents cfdb9c9 + eb32672 commit e7ad78e

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

fsthttp/request.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,7 @@ func (req *Request) Send(ctx context.Context, backend string) (*Response, error)
404404
)
405405

406406
switch underlyingReaderFrom(req.Body).(type) {
407-
case nil, *bytes.Buffer, *bytes.Reader, *strings.Reader:
407+
case nil, *bytes.Buffer, *bytes.Reader, *strings.Reader, *fastly.HTTPBody:
408408
streaming = false
409409
}
410410

integration_tests/request_upstream/main_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ func TestRequestUpstreamBody(t *testing.T) {
113113
{name: "bytes.Buffer", body: bytes.NewBuffer(body), size: bodySize},
114114
{name: "strings.Reader", body: strings.NewReader(string(body)), size: bodySize},
115115
{name: "io.NopCloser", body: io.NopCloser(bytes.NewReader(body)), chunked: true},
116-
{name: "fastly.HTTPBody", body: b, chunked: true},
116+
{name: "fastly.HTTPBody", body: b, size: bodySize},
117117
}
118118

119119
for _, tc := range testcases {

0 commit comments

Comments
 (0)