Respect floating transcript scroll intent

Keep the Swift live transcript panel from re-enabling bottom snapping when transcript content changes while the user has scrolled away.

Author: ComputelessComputer

plugins/windows/swift-lib/src/FloatingBarView.swift

@@ -626,24 +626,19 @@ private struct TranscriptScrollObserver: NSViewRepresentable {
     context.coordinator.isPinnedToBottom = $isPinnedToBottom
     DispatchQueue.main.async {
       context.coordinator.bind(to: view.enclosingScrollView)
-      context.coordinator.updatePinnedState()
     }
   }
 
   final class Coordinator {
     var isPinnedToBottom: Binding<Bool>?
     private weak var scrollView: NSScrollView?
     private var boundsObserver: NSObjectProtocol?
-    private var frameObserver: NSObjectProtocol?
     private let threshold: CGFloat = 20
 
     deinit {
       if let boundsObserver {
         NotificationCenter.default.removeObserver(boundsObserver)
       }
-      if let frameObserver {
-        NotificationCenter.default.removeObserver(frameObserver)
-      }
     }
 
     func bind(to scrollView: NSScrollView?) {
@@ -652,9 +647,6 @@ private struct TranscriptScrollObserver: NSViewRepresentable {
       if let boundsObserver {
         NotificationCenter.default.removeObserver(boundsObserver)
       }
-      if let frameObserver {
-        NotificationCenter.default.removeObserver(frameObserver)
-      }
 
       self.scrollView = scrollView
       guard let scrollView else { return }
@@ -668,15 +660,6 @@ private struct TranscriptScrollObserver: NSViewRepresentable {
         self?.updatePinnedState()
       }
 
-      scrollView.documentView?.postsFrameChangedNotifications = true
-      frameObserver = NotificationCenter.default.addObserver(
-        forName: NSView.frameDidChangeNotification,
-        object: scrollView.documentView,
-        queue: .main
-      ) { [weak self] _ in
-        self?.updatePinnedState()
-      }
-
       updatePinnedState()
     }